Add a local speechbot service#88
Conversation
Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
…into feature/local-speechbot
Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
…into feature/local-speechbot # Conflicts: # dockerfiles/harmoni/kinetic/base/dockerfile # dockerfiles/harmoni/noetic/base/dockerfile Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
emilyxzhou
requested review from
RMichaelSwan,
chrismbirmingham and
micolspitale93
Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
|
Both unit tests and rostests have been updated now, and the Rasa service is fully functional. |
micolspitale93
left a comment
micolspitale93
left a comment
There was a problem hiding this comment.
I have tested the rasa_greeter and it works fine for me.
I think that a brief tutorial on how to create a new rasa agent in the harmoni_bot package could be very helpful.
| @@ -0,0 +1 @@ | |||
| rasa==2.7.1 | |||
There was a problem hiding this comment.
Why the Rasa version differs between the requirements (2.7.1) file and the docker images (2.4.2)?
There was a problem hiding this comment.
Sorry, the dockerfiles have been updated to 2.7.1 now!
Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
…into feature/local-speechbot
…into feature/local-speechbot # Conflicts: # dockerfiles/harmoni/kinetic/base/dockerfile # dockerfiles/harmoni/noetic/base/dockerfile Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
RMichaelSwan
left a comment
RMichaelSwan
left a comment
There was a problem hiding this comment.
Great work! Once comments are addressed I'll approve it.
| class RasaService(HarmoniServiceManager): | ||
| """This is a class representation of a harmoni_dialogue service | ||
| (HarmoniServiceManager). It is essentially an extended combination of the | ||
| :class:`harmoni_common_lib.service_server.HarmoniServiceServer` and |
There was a problem hiding this comment.
I don't see how this line is true; HarmoniServiceServer is really just an extension of the HarmoniActionServer and you have not overridden any of its functions
| package_dir={'': 'src'}, | ||
| package_dir={ | ||
| '': 'src', | ||
| 'harmoni_bot': os.path.join('src', 'harmoni_bot') |
There was a problem hiding this comment.
As far as I know this line isn't needed. harmoni_common_lib doesn't have it and is imported the same way.
| from collections import deque | ||
|
|
||
| # Specific Imports | ||
| import mock |
Signed-off-by: emilyxzhou <zhouxemily@gmail.com>
| if [ "$RASA_ASSISTANT" == "rasa_example" ] || [ "$RASA_ASSISTANT" == "rasa_greeter" ] | ||
| then | ||
| cd "$RASA_DIR"/src/"$RASA_ASSISTANT" | ||
| rasa train && rasa run | ||
| else |
There was a problem hiding this comment.
This check works for now, but it doesn't work with future bots. Can we dynamically support based on what directories exist in the RASA_DIR?
| # | ||
| # dispatcher.utter_message(text="Hello World!") | ||
| # | ||
| # return [] |
There was a problem hiding this comment.
We can probably delete this
chrismbirmingham
left a comment
chrismbirmingham
left a comment
There was a problem hiding this comment.
I'd like to suggest we drop the rasa greeter from being committed here. I think we should include the example bot so there is an example, but that custom bot's should have their own repositories and be imported separately. @RMichaelSwan @micolspitale93 I'd like your opinions on this idea.
Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
Signed-off-by: Emily Zhou <zhouxemily@gmail.com>
|
@chrismbirmingham: I've removed |
4 participants
The Rasa bot currently has 2 default assistants to choose from, both defined in
harmoni_bot/src: rasa_example and rasa_greeter. The assistant can be changed in the configuration file by setting the rasa_assistant param value to the name of the Rasa bot's directory;rasa_assistant: "rasa_greeter"would direct the start_rasa_server script to run the server from therasa_bot/src/rasa_greeterdirectory.Currently, unit tests and rostests still need to be improved.