Make test binaries and test data installable#57
Conversation
Build gtest library as static, build tests with it and make test executables installable artifacts. Make test dataset used by the test binaries installable as well. Signed-off-by: Vladislav Dronov <vdronov@redhat.com>
Signed-off-by: Vladislav Dronov <vdronov@redhat.com>
nefigtut
requested review from
ElenaTyuleneva,
gbtucker,
nmizonov,
paveldyakov and
tizmajlo
as code owners
|
Hi, i'm a developer adding the intel-qpl package to RedHat Linux per Intel request. I'm not sure if this change is needed here upsteam, so please feel free to drop this PR out. Still, RHEL (and probably other distributions) would want test binaries available as build artifacts to run them during their QE stage outside the build process. So, this PR suggests building gtest library as static, so not to conflict with a system gtest if present and to lock possibly outdated gtest lib inside test binaries. Then it is used to build test binaries (which have to be renamed: qpl-func-tests and qpl-cross-tests). Could you please consider this PR for a possible inclusion? Thank you. |
gbtucker
left a comment
gbtucker
left a comment
There was a problem hiding this comment.
@nefigtut, we would like to do whatever is easier for maintainers but I'm not sure installing the tests by default is what most repos would want. Perhaps should leave for the disto-specific downstream stack or make optional with default off if that kind of patch is easier to maintain out-of-tree.
2 participants
Build gtest library as static, build tests with it and make test
executables installable artifacts. Make test dataset used by the
test binaries installable as well. Also fix a small shebang issue.