Drop centos6 and update pyperf test#1041
Open
mlim19 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Min Lim <min.yeol.lim@intel.com>
There was a problem hiding this comment.
Pull request overview
This PR removes CentOS 6 from the CI/test surface and updates Python profiling tests to make PyPerf assertions more reliable.
Changes:
- Removed
centos:6from the executable test container matrix and deleted the CentOS 6-specific PyPerf skip. - Updated async-profiler “minimum CentOS” test/build arg from
:6to:7. - Adjusted Python tests to rerun flaky cases and use a longer profiling duration for PyPerf.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_python.py | Adds flaky reruns and increases PyPerf profiling duration in tests. |
| tests/test_executable.py | Removes CentOS 6 + PyPerf skip logic (since CentOS 6 is dropped). |
| scripts/build_x86_64_executable.sh | Updates async-profiler minimum CentOS version to 7. |
| .github/workflows/build-test-deploy.yml | Drops centos:6 from the test container matrix. |
| .github/workflows/build-base-images.yml | Updates AP_CENTOS_MIN build arg to :7. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| with PythonProfiler(1000, 2, profiler_state, profiler_type, True, None, False, python_pyspy_process=[]) as profiler: | ||
| # Use longer duration for pyperf to ensure enough samples are collected for reliable assertions | ||
| duration = 5 if profiler_type == "pyperf" else 2 | ||
| with PythonProfiler(1000, duration, profiler_state, profiler_type, True, None, False, python_pyspy_process=[]) as profiler: |
| duration = 5 if profiler_type == "pyperf" else 2 | ||
| with PythonProfiler(1000, duration, profiler_state, profiler_type, True, None, False, python_pyspy_process=[]) as profiler: | ||
| try: | ||
| profile = snapshot_pid_profile(profiler, application_pid) |
| with PythonProfiler(1000, 2, profiler_state, profiler_type, True, None, True, python_pyspy_process=[]) as profiler: | ||
| # Use longer duration for pyperf to ensure enough samples are collected | ||
| duration = 5 if profiler_type == "pyperf" else 2 | ||
| with PythonProfiler(1000, duration, profiler_state, profiler_type, True, None, True, python_pyspy_process=[]) as profiler: |
Comment on lines
191
to
192
| with PythonProfiler(1000, duration, profiler_state, profiler_type, True, None, True, python_pyspy_process=[]) as profiler: | ||
| profile = snapshot_pid_profile(profiler, application_pid) |
Signed-off-by: Min Lim <min.yeol.lim@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots
Checklist: