Improve charset selection when parsing Delphi source files#447
Merged
Conversation
fourls
reviewed
Jun 3, 2026
fourls
approved these changes
Jun 3, 2026
fourls
requested changes
Jun 3, 2026
fourls
left a comment
fourls
left a comment
Collaborator
There was a problem hiding this comment.
Actually - needs a changelog entry.
The preference order is now: - Charset detected by `sonar-scanner` (applies only to `InputFile`) - Charset detected from BOM - Charset provided by `sonar.sourceEncoding` - ANSI charset specified by `sonar.delphi.codePage` - ANSI charset specified by `DCC_Codepage` - System native charset
cirras
force-pushed
the
improved-charset-selection
branch
from
6eb6ee9 to
758ddb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preference order is now:
sonar-scanner(applies only toInputFile)sonar.sourceEncodingsonar.delphi.codePageDCC_CodepageAnd just to muddy up the changeset a bit, I've refactored raw "encoding" strings to
Charset,Fixes #439.