fix(ci): set explicit component to match release tag format#156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-please v17 extracts component
''(empty string) from tags likev2.1.0. The root package path"."in the manifest doesn't automatically map to empty component, causingSet(0)on every run and no Release PR ever being created.Fix: restructure config to use
packages: {".": {"component": ""}}— this explicitly declares that the root package has an empty component, matching the tag format.Also: v2.1.0 GitHub Release has been created manually at tag
b6c82cfto bootstrap the anchor.Test plan
v2.1.0as the anchor (noSet(0))featorfixPR merge, release-please creates a Release PR automatically