fix(ci): add workflow_dispatch to bootstrap first Release PR#154
Merged
Conversation
…ease PR release-please v17 does not correctly split commits by path for this repo, so the first Release PR cannot be created automatically. Adding workflow_dispatch allows manually triggering the workflow with release-as=2.1.0 to create the Release PR; subsequent releases will work via release-please's own PR mechanism.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-please v17.6.0 does not correctly split commits by path for this repository —
Splitting 0 commits by pathon every run, so no Release PR is ever created automatically.Root cause is unclear (likely a v17 behaviour change with
release-type: simpleand root path"."). Addingworkflow_dispatchwith an optionalrelease-asinput allows manually triggering the workflow once withrelease-as: 2.1.0. After the resulting Release PR is merged, release-please will have its own GitHub Release withautorelease: taggedlabel as the anchor, and subsequent releases will work automatically.Also restores manifest key back to
"."(canonical for release-please root package).Test plan
release-asto2.1.0→ Runchore(main): release 2.1.0is opened