fix(ci): use empty-string manifest key to match release-please root component#153
Merged
Merged
Conversation
…omponent release-please v17 extracts component '' (empty) from tags like v2.0.0. The previous manifest key '.' did not match, so the v2.0.0 anchor was never found and no Release PR was created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-please v17 extracts component
''(empty string) from tags likev2.0.0wheninclude-component-in-tagis false. The manifest key"."does not match"", so thev2.0.0GitHub Release was never recognized as the last-release anchor — causingSet(0)and no Release PR.Fix: change
.release-please-manifest.jsonkey from"."to""so the tag component and manifest key match. Also removes the now-unnecessarylast-release-shaworkaround fromrelease-please-config.json.Test plan
2.1.0