Fix slow aggregation and slow cleaning#142
Closed
Merlin6nt wants to merge 3 commits into
Closed
Conversation
Optimized the aggregation command.
Contributor
|
Thanks for the proposal and for looking into the aggregation/cleanup path.\n\nAfter the rewrite to the new Pinboard stack, part of this PR is no longer relevant to the current codebase. In the new admin we kept the existing aggregate-on-read model, and the cleanup/retention concern is handled there in a different way.\n\nOne part of the original idea is still valid, and we already implemented it in the new codebase in PR #162: https://github.com/intaro/pinboard/pull/162\n\nSo for this old PR, I think the remaining changes are mostly historical for the legacy implementation and should not be carried over as-is. Thanks again for the analysis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.