Allows allow-clear option to be set in variables() without being overwriten

[averissimo]

Pull Request

• Fixes [Feature Request]: Allow variables() to clear selection #89

Changes description

• Only sets calculated default value if option is not present in ...
• Updates documentation
• Updates NEWS.md

[github-actions]

Unit Tests Summary

  1 files   11 suites   19s ⏱️
277 tests 263 ✅ 14 💤 0 ❌
411 runs  396 ✅ 15 💤 0 ❌

Results for commit b13272c.

♻️ This comment has been updated with latest results.

[github-actions]

Code Coverage Summary

Filename                  Stmts    Miss  Cover    Missing
----------------------  -------  ------  -------  --------------------------------------------------------------
R/as_picks.R                140      21  85.00%   64, 168-172, 183-187, 202-208, 230-232
R/assertion.R                 5       0  100.00%
R/call_utils.R              147      22  85.03%   23-28, 65, 132-138, 261, 281-282, 285-289, 294
R/helpers.R                   9       0  100.00%
R/interaction.R              42       1  97.62%   105
R/module_merge.R            257       2  99.22%   328, 609
R/module_picks.R            324      23  92.90%   76-82, 101, 138-139, 328-330, 332-336, 474, 522, 560, 572, 580
R/picks.R                   191       1  99.48%   353
R/print.R                    36       2  94.44%   50, 58
R/resolver.R                141      15  89.36%   110-118, 284-289
R/tidyselect-helpers.R       29       0  100.00%
R/tm_merge.R                 54       0  100.00%
R/ui_containers.R            55       0  100.00%
R/zzz.R                       5       5  0.00%    3-11
TOTAL                      1435      92  93.59%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  -------
R/picks.R        +8       0  +0.02%
TOTAL            +8       0  +0.04%

Results for commit: b13272c

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
badge_dropdown	👶		$+0.15$	$+1$	$+1$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
assertion	💀	$0.02$	$-0.02$	unnamed
badge_dropdown	👶		$+0.15$	shinytest2_badge_dropdown_is_visible_when_clicking_on_it_multiple_times
picks	👶		$+0.01$	variables_allow_clear_attribute_sets_allow_clear_manually_to_FALSE
picks	👶		$+0.01$	variables_allow_clear_attribute_sets_allow_clear_manually_to_TRUE

Results for commit 1bb4130

♻️ This comment has been updated with latest results.

[osenan]

Good job! Thanks for the changes. Can you go to test-picks.R section: "variables () allow-clear attribute" (line 407) and add another test where we actually set the value of allow-clear? The existing tests are calculating the value. It is a very simple test but it would confirm that this feature works and it would ensure that we do not break this feature.
Apart from the test, just fix the typo and we can merge.