Skip to content

Temporary remove tm_gtsummary module#1001

Open
averissimo wants to merge 1 commit into
mainfrom
1000-remove_gtsummary
Open

Temporary remove tm_gtsummary module#1001
averissimo wants to merge 1 commit into
mainfrom
1000-remove_gtsummary

Conversation

@averissimo

@averissimo averissimo commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Changes description

  • Removes all files introduced by gtsummary, but not some of the fixes introduced
  • Replaces gtsummary module with scatterplot in test-utils.R

@averissimo averissimo added the core label Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/geom_mosaic.R                  73       0  100.00%
R/tm_a_pca.R                    852       0  100.00%
R/tm_a_regression.R             750     391  47.87%   496-523, 530-533, 540-541, 545-555, 559, 563-575, 580-595, 600-622, 625-633, 637-665, 670-680, 683-709, 716-740, 743-768, 775-782, 785-811, 818-846, 849-874, 881-900, 903-929, 936-950, 953-979, 1004, 1008
R/tm_data_table.R               204       8  96.08%   110, 115-120, 330
R/tm_file_viewer.R              172      50  70.93%   141-152, 156-163, 165-167, 172-182, 184, 204, 229-235, 237-238, 240, 244-250
R/tm_front_page.R               143       0  100.00%
R/tm_g_association.R            320      72  77.50%   226-294, 319, 325, 474, 488
R/tm_g_bivariate.R              672     196  70.83%   332-471, 505, 511-514, 585, 590, 595, 616-618, 655-658, 668-682, 684-685, 712-721, 763, 829, 940, 987, 989, 991, 998-1008
R/tm_g_distribution.R          1115      60  94.62%   418-426, 432-435, 474-475, 477, 479, 488, 490, 494-497, 501-504, 507, 519-520, 575, 586, 600, 895, 1082-1086, 1155-1159, 1161-1167, 1298-1301, 1319-1321, 1407-1408
R/tm_g_response.R               345      87  74.78%   184-185, 192, 198, 259-325, 348-352, 425, 430, 447-453, 531, 537, 550
R/tm_g_scatterplot.R            709     259  63.47%   359-501, 534-537, 575, 624, 636, 650, 667, 672, 698-711, 787-798, 837, 845-882, 894-896, 906-912, 919-921, 932-940, 942-943, 945, 949, 983-996, 1040, 1060
R/tm_g_scatterplotmatrix.R      336     145  56.85%   262-360, 383, 386, 441-447, 461-464, 466, 489-492, 504, 507-519, 525-526, 532-534, 586-594
R/tm_missing_data.R            1180     167  85.85%   129, 488, 494, 507, 512, 532-538, 547-553, 620-635, 676, 680, 721, 739-746, 771, 787-790, 848-927, 931-933, 964-971, 1104, 1241, 1280, 1332-1334, 1344-1364, 1472, 1474, 1477-1478
R/tm_outliers.R                1029     186  81.92%   400, 428, 438-439, 441-442, 517-531, 533, 613, 616, 654-706, 709-747, 759, 790, 809, 812-827, 888-891, 965-993, 1117, 1220-1223, 1227, 1230-1233, 1239-1248, 1250, 1254-1263, 1266-1267, 1269
R/tm_rmarkdown.R                159       0  100.00%
R/tm_t_crosstable.R             263      56  78.71%   227-269, 292-293, 309, 318, 425, 438-447
R/tm_variable_browser.R         887      27  96.96%   395, 597, 812-826, 956, 984, 986, 1058-1059, 1067, 1165, 1246, 1278, 1310
R/utils.R                       148      21  85.81%   146, 177, 227, 288-291, 300-306, 314, 350, 353, 366-371
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          9359    1727  81.55%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  -------
R/utils.R         0      +6  -4.05%
TOTAL             0      +6  -0.35%

Results for commit: ab5944d

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Unit Tests Summary

    1 files     36 suites   27m 4s ⏱️
  663 tests   662 ✅ 1 💤 0 ❌
1 288 runs  1 287 ✅ 1 💤 0 ❌

Results for commit ab5944d.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_pca 💔 $228.05$ $+9.05$ $0$ $0$ $0$ $0$
shinytest2-tm_a_regression 💔 $91.28$ $+3.81$ $0$ $0$ $0$ $0$
shinytest2-tm_data_table 💔 $37.45$ $+1.52$ $0$ $0$ $0$ $0$
shinytest2-tm_file_viewer 💔 $44.66$ $+1.64$ $0$ $0$ $0$ $0$
shinytest2-tm_g_distribution 💚 $122.62$ $-2.26$ $0$ $0$ $0$ $0$
shinytest2-tm_g_response 💚 $52.42$ $-1.53$ $0$ $0$ $0$ $0$
shinytest2-tm_g_scatterplot 💚 $144.41$ $-2.66$ $0$ $0$ $0$ $0$
shinytest2-tm_g_scatterplotmatrix 💚 $70.22$ $-2.37$ $0$ $0$ $0$ $0$
shinytest2-tm_outliers 💚 $180.63$ $-3.14$ $0$ $0$ $0$ $0$
shinytest2-tm_variable_browser 💚 $103.78$ $-2.10$ $0$ $0$ $0$ $0$
tm_a_pca 💚 $17.44$ $-1.75$ $0$ $0$ $0$ $0$
tm_g_bivariate 💚 $8.77$ $-1.34$ $0$ $0$ $0$ $0$
tm_gtsummary 💀 $13.73$ $-13.73$ $-29$ $0$ $0$ $0$
tm_outliers 💚 $53.39$ $-2.21$ $0$ $0$ $0$ $0$
utils 💚 $11.39$ $-3.20$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
examples 💀 $0.07$ $-0.07$ example_tm_gtsummary.Rd
shinytest2-tm_a_pca 💔 $16.04$ $+1.28$ e2e_tm_a_pca_Changing_output_encodings_for_plot_type_does_not_generate_errors.
shinytest2-tm_a_pca 💔 $34.62$ $+1.95$ e2e_tm_a_pca_Changing_output_encodings_of_plot_type_hides_and_shows_options.
shinytest2-tm_a_pca 💔 $15.60$ $+1.00$ e2e_tm_a_pca_Changing_output_encodings_of_standardization_does_not_generate_errors.
shinytest2-tm_a_pca 💔 $14.87$ $+1.18$ e2e_tm_a_pca_Color_by_columns_data_extract_must_be_from_non_selected_variable_set.
shinytest2-tm_g_bivariate 💚 $41.51$ $-1.94$ e2e_tm_g_bivariate_Setting_encoding_inputs_produces_outputs_without_validation_errors.
shinytest2-tm_g_distribution 💚 $79.65$ $-1.01$ e2e_tm_g_distribution_Module_is_initialised_with_the_specified_defaults.
shinytest2-tm_g_response 💚 $20.14$ $-1.08$ e2e_tm_g_response_encoding_inputs_produce_output_without_validation_errors.
shinytest2-tm_g_scatterplot 💚 $91.50$ $-1.41$ e2e_tm_g_scatterplot_The_encoding_inputs_are_set_without_validation_errors.
shinytest2-tm_variable_browser 💚 $16.08$ $-1.01$ e2e_tm_variable_browser_Selecting_treat_variable_as_factor_changes_the_table_headers.
tm_gtsummary 💀 $0.01$ $-0.01$ tm_gtsummary_input_validation_accepts_valid_decorators
tm_gtsummary 💀 $0.01$ $-0.01$ tm_gtsummary_input_validation_creates_a_teal_module_object_with_list_of_data_extract_specs
tm_gtsummary 💀 $0.01$ $-0.01$ tm_gtsummary_input_validation_fails_when_by_allows_multiple_selection
tm_gtsummary 💀 $0.01$ $-0.01$ tm_gtsummary_input_validation_fails_when_by_is_not_a_data_extract_spec_or_list
tm_gtsummary 💀 $0.01$ $-0.01$ tm_gtsummary_input_validation_fails_when_col_label_is_not_character
tm_gtsummary 💀 $0.01$ $-0.01$ tm_gtsummary_input_validation_fails_when_decorators_has_invalid_object_types
tm_gtsummary 💀 $0.01$ $-0.01$ tm_gtsummary_input_validation_fails_when_decorators_is_to_a_different_object
tm_gtsummary 💀 $0.01$ $-0.01$ tm_gtsummary_input_validation_fails_when_include_is_not_a_data_extract_spec_or_list
tm_gtsummary 💀 $0.01$ $-0.01$ tm_gtsummary_input_validation_fails_when_label_is_not_a_string
tm_gtsummary 💀 $0.00$ $-0.00$ tm_gtsummary_input_validation_pass_when_include_allows_multiple_selection
tm_gtsummary 💀 $0.01$ $-0.01$ tm_gtsummary_module_creation_accepts_crane_tbl_roche_summary_arguments
tm_gtsummary 💀 $0.01$ $-0.01$ tm_gtsummary_module_creation_creates_a_module_that_is_bookmarkable
tm_gtsummary 💀 $0.01$ $-0.01$ tm_gtsummary_module_creation_creates_a_module_with_datanames_taken_from_data_extracts
tm_gtsummary 💀 $0.02$ $-0.02$ tm_gtsummary_module_creation_creates_a_teal_module_object
tm_gtsummary 💀 $0.01$ $-0.01$ tm_gtsummary_module_creation_creates_a_teal_module_object_with_list_of_data_extract_specs
tm_gtsummary 💀 $2.66$ $-2.66$ tm_gtsummary_module_server_behavior_server_function_executes_successfully_through_module_interface
tm_gtsummary 💀 $2.32$ $-2.32$ tm_gtsummary_module_server_behavior_server_function_generates_table_with_col_label_
tm_gtsummary 💀 $3.40$ $-3.40$ tm_gtsummary_module_server_behavior_server_function_generates_table_with_include_being_NULL
tm_gtsummary 💀 $5.16$ $-5.16$ tm_gtsummary_module_server_behavior_with_decorators_one_decorator_executes_successfully
tm_gtsummary 💀 $0.05$ $-0.05$ tm_gtsummary_module_ui_behavior_returns_a_htmltools_tag_or_taglist_with_minimal_arguments
tm_outliers 💚 $3.28$ $-1.01$ tm_outliers_module_server_behavior_server_function_handles_both_split_outliers_and_order_by_outlier
tm_t_crosstable 💔 $0.65$ $+1.05$ tm_t_crosstable_module_server_behavior_server_function_generates_table_with_show_total_enabled

Results for commit 1de3364

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Temporary remove tm_gtsummary from main

1 participant