Add support for color assets#42
Draft
darknoon wants to merge 1 commit into
Draft
Conversation
darknoon
commented
Oct 24, 2025
Comment on lines
+482
to
+493
| // Create JSON representation of the color | ||
| CGFloat red = 0, green = 0, blue = 0, alpha = 0; | ||
| [rgbColor getRed:&red green:&green blue:&blue alpha:&alpha]; | ||
|
|
||
| NSDictionary *colorInfo = @{ | ||
| @"red": @(red), | ||
| @"green": @(green), | ||
| @"blue": @(blue), | ||
| @"alpha": @(alpha), | ||
| @"hex": [NSString stringWithFormat:@"#%02X%02X%02X", (int)(red * 255), (int)(green * 255), (int)(blue * 255)] | ||
| }; | ||
|
|
Author
There was a problem hiding this comment.
Sorry, this is a bit out of sync with what goes on the pasteboard. (I used claude 4.5 for this and it went a bit haywire).
How do we think colors should be saved?
|
There are 2 issues:
Sample |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for reading and displaying color assets from .car files.
Changes
UI & Display
Export & Pasteboard
color(display-p3 ...)for P3 colorsTesting
Tested with Safari.'s Assets.car, reads colors ok