converted project to use retrofit2 with optional custom OkHttpClient#8
Open
dpmedeiros wants to merge 1 commit into
Open
converted project to use retrofit2 with optional custom OkHttpClient#8dpmedeiros wants to merge 1 commit into
dpmedeiros wants to merge 1 commit into
Conversation
|
This would be extremely helpful for my project. All my existing network stack stuff is on Retrofit2 and I don't relish the idea of having both Retrofit1 and Retrofit2 in my apk. |
Author
|
You're welcome to refork and use my branch from this PR...I have not gotten a response in three months. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the project to use retrofit 2/okHttp 3, which many new projects are converting to. I noticed that the project hasn't been updated in two years so I thought I would throw this over to you and see what you think.
You can customize the OkHttpClient to use (for instance, to override connection/read timeouts among other things) using Builder.okHttpClient(). If this is not specified it uses a client with default settings.