69 medunda does not support composedbasin#71
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Medunda’s downloader CLI to accept domain specifications either as a YAML path or as a basin:<id> string, and extends domain handling to support composed (multi-component) basins by introducing a MultiPolygonalDomain.
Changes:
- Switch
--domainCLI parsing fromPathto a richer parser (domain_from_string) supportingbasin:<uuid>and YAML files. - Add
MultiPolygonalDomain, bounding-box merge support, and composed-basin expansion logic indomain_from_basin. - Add a new basin-based domain descriptor (
domains/CentralMediterranean.yaml).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/medunda/downloader.py |
Parses --domain into a ConcreteDomain at CLI parse time and passes it through download/validation. |
src/medunda/domains/domain.py |
Adds composed-basin support via domain_from_basin, introduces MultiPolygonalDomain, and adds domain_from_string + YAML rename. |
domains/CentralMediterranean.yaml |
New example/config domain using geometry.type: basin. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
spiani
force-pushed
the
69-medunda-does-not-support-composedbasin
branch
from
850b0e1 to
032873a
Compare
Copilot stopped work on behalf of
spiani due to an error
June 3, 2026 11:00
spiani
force-pushed
the
69-medunda-does-not-support-composedbasin
branch
from
f89b44f to
6954e69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.