argo downloader scripts#140
Merged
Merged
Conversation
added default values to script arguments
Co-authored-by: Copilot <copilot@github.com>
gbolzon
reviewed
Apr 28, 2026
| ''', formatter_class=argparse.RawTextHelpFormatter) | ||
|
|
||
|
|
||
| parser.add_argument( '--remotedir',"-r", |
Collaborator
There was a problem hiding this comment.
rimuovi l'argomento, usa il path hardcoded
gbolzon
reviewed
Apr 28, 2026
|
|
||
| local_tmp_download_path = local_coriolis_dir / "download" / "tmp" | ||
|
|
||
| def parse_float_line(line): |
Collaborator
There was a problem hiding this comment.
aggiungi la docstring a tutte le funzioni
gbolzon
reviewed
Apr 28, 2026
| already_downloaded_floats = set(line.strip() for line in f) | ||
| for line in already_downloaded_floats: | ||
| float_path_remote, float_path_local, float_file_name = parse_float_line(line) | ||
| if float_path_local is not None and \ |
Collaborator
There was a problem hiding this comment.
definisci una condition_to_download =
evitiamo gli if su più righe
if condition_to_download:
gbolzon
reviewed
Apr 28, 2026
| if filename.startswith('SD') and filename.endswith('.nc'): | ||
| sr_path = local_float_dir / ('SR' + filename[2:]) | ||
| if sr_path.exists(): | ||
| os.remove(sr_path) No newline at end of file |
Collaborator
There was a problem hiding this comment.
ci vuole un print per ogni file aggiunto o eliminato
print statements of downloaded and removed files, readability of conditions to download, removed 'remotedir' argument, docstrings of the functions, facultative 'getcommand' argument in argo_downloader.py, added optional lines and comments to launcher.sh
…cleaned launcher.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #139