6 merge neccton dev#7
Open
ggalli00 wants to merge 10 commits into
Open
Conversation
…d / fixed. Values hard-coded in shared.F90
…n with p_pu_rn split parameter
Closed
There was a problem hiding this comment.
Pull request overview
Ports several biogeochemical process updates from the neccton branch into the FABM-BFM Fortran implementation and its reference configuration, targeting updated O2/C stoichiometry handling, chlorophyll quota limits, and nutrient-stress respiration behavior.
Changes:
- Introduces O2:C stoichiometry scaling factors for respiration and carbon fixation and applies them to O2 fluxes in multiple pelagic components.
- Adds a minimum Chl:C quota parameter (
p_qlcmin) and updates the chlorophyll synthesis formulation accordingly. - Implements nutrient-stress “extra respiration” partitioning (
p_pu_rn) with a new diagnostic (flPIO3c) and updates the multispectral 2xDetritus YAML with the new parameters.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
shared.F90 |
Adds shared stoichiometry scaling constants used across pelagic processes. |
Phyto.F90 |
Adds nutrient-stress respiration partitioning + diagnostic, introduces minimum Chl:C, and applies O2:C scaling to O2 fluxes. |
PelBac.F90 |
Applies O2:C respiration scaling to bacterial O2 consumption. |
MicroZoo.F90 |
Applies O2:C respiration scaling to microzooplankton O2 consumption. |
MesoZoo.F90 |
Applies O2:C respiration scaling to mesozooplankton O2 consumption. |
fabm_multispectral_2xDetritus.yaml |
Adds new configuration parameters (p_pu_rn, p_qlcmin) and updates some tuned values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
correct sign of O2 flux related to nutrient-stress respiration Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
initialise netgrowth (=run) outside if p_netgrowth (in case p_netgrowth=false) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
initialise units of p_pu_rn + default=0.0 Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all new processes introduced in neccton (that I could remember of) ported here, these are: 1. non-1.0 O2 / CO2 stoichiometry of respiration / C fixation, 2. minimum Chl/C ratio, 3. extra respiration under nutrient stress. The code compiles and runs (gotm-fabm-bfm). New parameters added to fabm_multispectral_2xDetritus.yaml