Skip to content

6 merge neccton dev#7

Open
ggalli00 wants to merge 10 commits into
masterfrom
6-merge_neccton_dev
Open

6 merge neccton dev#7
ggalli00 wants to merge 10 commits into
masterfrom
6-merge_neccton_dev

Conversation

@ggalli00

@ggalli00 ggalli00 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

all new processes introduced in neccton (that I could remember of) ported here, these are: 1. non-1.0 O2 / CO2 stoichiometry of respiration / C fixation, 2. minimum Chl/C ratio, 3. extra respiration under nutrient stress. The code compiles and runs (gotm-fabm-bfm). New parameters added to fabm_multispectral_2xDetritus.yaml

Copilot AI review requested due to automatic review settings June 9, 2026 15:28
@ggalli00 ggalli00 linked an issue Jun 9, 2026 that may be closed by this pull request
@ggalli00 ggalli00 requested a review from plazzari June 9, 2026 15:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ports several biogeochemical process updates from the neccton branch into the FABM-BFM Fortran implementation and its reference configuration, targeting updated O2/C stoichiometry handling, chlorophyll quota limits, and nutrient-stress respiration behavior.

Changes:

  • Introduces O2:C stoichiometry scaling factors for respiration and carbon fixation and applies them to O2 fluxes in multiple pelagic components.
  • Adds a minimum Chl:C quota parameter (p_qlcmin) and updates the chlorophyll synthesis formulation accordingly.
  • Implements nutrient-stress “extra respiration” partitioning (p_pu_rn) with a new diagnostic (flPIO3c) and updates the multispectral 2xDetritus YAML with the new parameters.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
shared.F90 Adds shared stoichiometry scaling constants used across pelagic processes.
Phyto.F90 Adds nutrient-stress respiration partitioning + diagnostic, introduces minimum Chl:C, and applies O2:C scaling to O2 fluxes.
PelBac.F90 Applies O2:C respiration scaling to bacterial O2 consumption.
MicroZoo.F90 Applies O2:C respiration scaling to microzooplankton O2 consumption.
MesoZoo.F90 Applies O2:C respiration scaling to mesozooplankton O2 consumption.
fabm_multispectral_2xDetritus.yaml Adds new configuration parameters (p_pu_rn, p_qlcmin) and updates some tuned values.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Phyto.F90 Outdated
Comment thread Phyto.F90 Outdated
Comment thread Phyto.F90 Outdated
Comment thread shared.F90 Outdated
Comment thread fabm_multispectral_2xDetritus.yaml
Giovanni Galli and others added 4 commits June 9, 2026 17:43
correct sign of O2 flux related to nutrient-stress respiration

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
initialise netgrowth (=run) outside if p_netgrowth (in case p_netgrowth=false)

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
initialise units of p_pu_rn + default=0.0

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

merge_neccton_dev

3 participants