Conversation
… in each layer is greater than -5
Collaborator
|
I have committed the last changes, tested locally the model with different variants of the parameters and of the input file and everything goes smoothly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes does this PR introduce?
Feature additions to the rbcs package: two new conditions that control when temperature relaxation is applied.
What is the current behaviour?
RBCS_ADD_TENDENCYapplies the temperature relaxation unconditionally at every timestep as long asuseRBCtemp = .TRUE.. There is no mechanism to apply relaxation only up to a prescribed time of the simulation. rbcsVanishingTime allows only to ramp down the relaxation linearly with time, but it is not possible to switch it off abruptly at a given time. Moreover it is not possible to apply relaxation only in a prescribed time window of the day, for instance at night hours.What is the new behaviour
Two independent conditions are evaluated before the temperature tendency is applied:
rbcsTempHalfWindowthat can be set in data.rbcs. If that parameter is not set it will assimilate continuously for the whole day. The parameter set the length of half window, so if we want to assimilate from 22:00 to 02:00 its value will berbcsTempHalfWindow=7200.. If the temperature relaxation file contains daily records of the SST at 00H, to assimilate correctly we need to setup the relaxation parameters as follows:and the file must contains a number of records equal to the number of simulation days +1. rbcsForcingCycle can be set to 86400*Nrecords for periodic forcing (for instance for a two year hindcast with one year records).
If another variable is assimilated, e.g. salinity, the corresponding relaxation file must contain the same number of records.
Does this PR introduce a breaking change?
These modifications affect how the temperature relaxation file should be prepared if these new features are going to be used, but the behavior is the same of before if the file is full of "good" values, or also in the accidental case in which there are NaN (in this case relaxation is done with NaN as before).
Other information:
Suggested addition to
tag-index(To avoid unnecessary merge conflicts, please don't update
tag-index. One of the admins will do that when merging your pull request.)