Sync 2 Inkeep OSS Changes#770
Merged
Merged
Conversation
* chore: rename mermaid-wysiwyg to visimer
Directory public/mermaid-wysiwyg is now public/visimer. NPM packages
move from @inkeep/mermaid-wysiwyg-{core,dom,react,codemirror,monaco}
to scoped @visimer/{core,dom,react,codemirror,monaco}. Copybara mirror
target moves from inkeep/mermaid-wysiwyg to inkeep/visimer.
Also reverts the earlier site→mermaidraw rename inside the subtree:
apps/site stays apps/site (it's the demo site, not the library).
OK consumer stays on @inkeep/mermaid-wysiwyg-{core,dom}@0.1.0 for now;
follow-up once @visimer/* publishes to npm.
* fix(check-pre-push-mode.test): sort SUBTREES expected list after visimer rename
alphabetical order puts public/open-knowledge before public/visimer.
GitOrigin-RevId: 7ab9082a77d8333529e255280de2321e0e35fcf0
…its via a signal (#2795) Fixes #692: `ok start` spawns a detached `ok ui` process for the editor shell. On Ctrl+C (SIGINT/SIGTERM) the CLI destroyed the collab server but never signalled the UI child, which lingered until its 12h safety timer — holding its port so the next `ok start` bound a different one. The signal path now runs the same guarded UI teardown as idle-shutdown, before destroy releases server.lock. The SIGTERM → grace-poll → SIGKILL escalation is factored out of `buildIdleShutdownHandler` into a shared `teardownUiSibling`, so both call sites honor the SAME ownership guard: `spawnedUiPid` scopes the kill to the sibling this process spawned, leaving a lock holder we did not spawn (a desktop shell, another session) untouched. `BootedStartServer` now exposes `spawnedUiPid` so the signal handler passes the owned pid through; the signal path's teardown is wrapped so a failure there never bypasses destroy(). Reworks community PR #702 by @Adityakk9031, preserving the `spawnedUiPid` ownership guard that #702 dropped and fixing its changeset (correct package name, no BOM). Adds `teardownUiSibling` unit tests covering the signal path's guard. Co-authored-by: Aditya kumar singh <143548997+Adityakk9031@users.noreply.github.com> GitOrigin-RevId: 67089dae1d813dbd3470369c7fd73142801a67c7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copybara-translated 2 Inkeep OSS changes. Rebase-merge this PR so the prepared commits land directly on public main.
Commits:
ok uisibling whenok startexits via a signal (#2795)