fix(desktop): quit cleanly on SIGTERM/SIGINT/SIGHUP so termination isn't misreported as a crash (#2821)#768
Merged
Merged
Conversation
…n't misreported as a crash (#2821) A termination signal (macOS logout, killall, Activity Monitor's Quit, or a parent process) is an orderly request to stop, not an app crash. The main process had no signal handlers, so Node's default disposition terminated it without running Electron's before-quit / will-quit sequence. The dirty-shutdown sentinel was left behind and the next launch misread the session as a crash (previous session ended without a clean quit), inviting a bug report. Add installSignalCleanQuit: on the first SIGTERM/SIGINT/SIGHUP it clears the sentinel synchronously (durable against a SIGKILL escalation racing the async teardown) then drives app.quit() so the full will-quit teardown still runs. Mirrors the existing teardown-signal handling in the sibling utility processes (pty-host, server-entry) and is not a userland uncaughtException handler. Genuine crashes still prompt: a native crash delivers no signal, and the boot-time minidump scan stays the authoritative native-crash signal. PRD-7522 GitOrigin-RevId: 461bc150d19345eb43bb33c8698cce802333b4d6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copybara-translated 1 Inkeep OSS change. Rebase-merge this PR so the prepared commit lands directly on public main.