fix(open-knowledge): shadcn lint fix button and settings search borders (#2838)#765
Merged
Conversation
…rs (#2838) The Fix button in the editor lint hover popup now gets its styling from the shared shadcn buttonVariants recipe instead of hand-rolled CSS on Fumadocs tokens, so it matches every other primary button. The class ok-lint-tooltip-fix stays as a bare selector hook for tests plus the hidden-attribute guard. The settings sidebar search previously drew a border box around the whole cmdk surface, doubling up with the input wrapper's stock border-b at the box bottom. The input wrapper is now boxed like a shadcn Input and the results list gets the PopoverContent panel treatment, matching the app's other Command dropdowns (NewItemDialog, code block language picker, icon picker). PRD-7524 GitOrigin-RevId: 666b53e1c2fe0bc8fb576e44d98129cc6aeed422
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copybara-translated 1 Inkeep OSS change. Rebase-merge this PR so the prepared commit lands directly on public main.