Dispose 13 dormant e2e suites: wire 8, retire 2, keep 3 (#2824)#759
Merged
Conversation
* Dispose 13 dormant e2e suites: wire 8, retire 2, keep 3 13 tests/stress/*.e2e.ts suites existed on disk but were never in the packages/app test:e2e file list, so they never ran in any CI tier. Full disposition: - Promote 8 into test:e2e: slash-command-auto-open, graph-panel-surfaces, clipboard-relative-url-source-fallback (already green) plus asset-embed-real-fidelity, prop-upload, rename-content-preservation, rename-consolidation, outline-navigation (drift repaired to current behavior: file-attachment wiki-embed shape, doc-relative src normalization, kind-bearing rename payload, RFC 9457 success envelopes, primed-layout outline scroll). - Retire edit-with-ai and timeline-diff-sidepane (superseded designs); delete the dead EditWithAiPopover component plus its two orphaned dom tests, and regenerate the Lingui catalogs (5 now-unused strings). - Keep 3 excluded with updated blockers: frontmatter-edit (needs a malformed-frontmatter disk fixture), list-keymap (pins #2817/#2818), okignore-settings (pins #2816; its 4 nav-drift tests repaired, the 2 Hide tests stay red as executable specs of the bug). Reconcile both gated registries (EXCLUDED_FROM_PR_TIER in check-e2e-list-membership.test.mjs and E2E_CI_EXCLUSIONS in e2e-ci-ledger.ts) to the same 3 entries. * Address review: dedup primeFullLayout, fix stale comment and mock - Extract the duplicated primeFullLayout helper into _helpers/editor-state.ts (the established e2e shared-helper barrel) and import it from both outline-navigation and outline-toolbar-occlusion; drops a 43-line verbatim copy. - prop-upload: update the header comment that still claimed the file is NOT in the CI test:e2e list (this change wires it in). - rename-content-preservation: drop the stale ok:true from the lagging /api/pages mock so it matches the flat RFC 9457 success envelope. * Fix stale timeline coverage comment and migrate its dom test to vitest The retired timeline-diff-sidepane.e2e.ts was still cited as the browser coverage for the expand/diff/restore flow. State the truth instead: the flow was redesigned into the TimelineDiffPane overlay in #2607 and has no browser-tier coverage yet. Touching the file also brings it under the no-new-bun-test-imports guard, so its mock.module and bun:test imports move to vi.mock and vitest. 4/4 green under test:dom. GitOrigin-RevId: 3cbed03802150b7a14e10b0b3a46981ac762ecb9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copybara-translated 1 Inkeep OSS change. Rebase-merge this PR so the prepared commit lands directly on public main.