Skip to content

Fix the "Download manually" link in OK Desktop's update notices. When… #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inkeep-oss-sync merged 1 commit into from
Jul 1, 2026
Merged

Fix the "Download manually" link in OK Desktop's update notices. When… #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-download-manually-link.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@inkeep/open-knowledge": patch
---

Fix the "Download manually" link in OK Desktop's update notices. When an update fails to install (the "Update to X didn't install" card) or the app detects it hasn't received updates in a while, the manual-download link now points at the GitHub Releases page (https://github.com/inkeep/open-knowledge/releases) where the signed DMGs actually live, instead of a marketing URL that returned a 404.
6 changes: 3 additions & 3 deletions packages/app/src/components/UpdateNotices.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ describe('Notice A cross-window relaunch — ok:update:relaunching', () => {
attachUpdateSubscribers(castBridge(bridge), addNotice);
bridge._relaunchFailed?.({
version: '0.16.0-beta.3',
downloadUrl: 'https://inkeep.com/open-knowledge/download',
downloadUrl: 'https://github.com/inkeep/open-knowledge/releases',
});
const notice = addNotice.mock.calls.at(-1)?.[0] as UpdateNotice;
expect(notice.id).toBe('install-failed-0.16.0-beta.3');
Expand All @@ -270,7 +270,7 @@ describe('Notice A cross-window relaunch — ok:update:relaunching', () => {
const bridge = makeFakeBridge();
const addNotice = mock<(notice: UpdateNotice) => void>(() => {});
attachUpdateSubscribers(castBridge(bridge), addNotice);
const url = 'https://inkeep.com/open-knowledge/download';
const url = 'https://github.com/inkeep/open-knowledge/releases';
bridge._relaunchFailed?.({ version: '0.16.0-beta.3', downloadUrl: url });
const notice = addNotice.mock.calls.at(-1)?.[0] as UpdateNotice;
notice.action?.onClick();
Expand Down Expand Up @@ -613,7 +613,7 @@ describe('Notice C — ok:update:stuck-hint', () => {
const bridge = makeFakeBridge();
const addNotice = mock<(notice: UpdateNotice) => void>(() => {});
attachUpdateSubscribers(castBridge(bridge), addNotice);
const downloadUrl = 'https://inkeep.com/open-knowledge/download';
const downloadUrl = 'https://github.com/inkeep/open-knowledge/releases';
bridge._stuckHint?.({ downloadUrl });
expect(addNotice).toHaveBeenCalledTimes(1);
const notice = addNotice.mock.calls[0]?.[0] as UpdateNotice;
Expand Down
2 changes: 1 addition & 1 deletion packages/desktop/src/main/auto-updater.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ export const RELAUNCH_WATCHDOG_MS = 15_000;

export const STUCK_HINT_THRESHOLD_MS = 7 * 24 * 60 * 60 * 1000;

export const STUCK_HINT_DOWNLOAD_URL = 'https://inkeep.com/open-knowledge/download';
export const STUCK_HINT_DOWNLOAD_URL = 'https://github.com/inkeep/open-knowledge/releases';

const WHATS_NEW_LIVE_WINDOW_MS = 60_000;

Expand Down