Stop showing auto-update notices in unpackaged dev builds. A dev…#398
Merged
Conversation
Dev desktop builds never download or install updates, but boot-time update state (attemptedInstall / versionPendingInstall / lastSeenVersion) could still surface the 'Update to X didn't install' banner, the staged-update relaunch banner, and the 'what's new' toast from stale local state. Gate every user-visible update notice on the same isPackaged || forceDevBypass signal that already gates update checks: the boot-time failed-install and what's-new emits in auto-updater.ts, and the late-window re-broadcast in index.ts. OK_UPDATER_FORCE_DEV stays as the escape hatch so the manual update smoke can still observe the toasts in a dev build. GitOrigin-RevId: 3e39659a329cdceaca428611fe3caac67b412a21
![inkeep-internal-ci[bot]](https://avatars.githubusercontent.com/in/2806322?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated approval from agents-private public-mirror-sync (run: https://github.com/inkeep/agents-private/actions/runs/28471294990). Source of truth is the monorepo; direct edits on inkeep/open-knowledge are overwritten on next sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop showing auto-update notices in unpackaged dev builds. A dev desktop app never downloads or installs updates, so the boot-time "Update to X didn't install" banner, the staged-update relaunch banner, and the "what's new" toast were all noise driven by stale local state. They're now gated on the same signal that gates update checks (
app.isPackaged), with theOK_UPDATER_FORCE_DEVescape hatch preserved for the manual update smoke.