Skip to content

Fix image and file paste/drop in the packaged desktop app, which… #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inkeep-oss-sync merged 1 commit into from
Jun 30, 2026
Merged

Fix image and file paste/drop in the packaged desktop app, which… #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/dark-humans-jump.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@inkeep/open-knowledge-server": patch
"@inkeep/open-knowledge": patch
---

Fix image and file paste/drop in the packaged desktop app, which failed with an "internal server error" toast (the upload endpoint returned HTTP 500).
27 changes: 27 additions & 0 deletions packages/cli/src/tsdown-bundle-coverage.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,30 @@ describe('tsdown alwaysBundle covers every cli runtime dep', () => {
});
}
});

describe('tsdown alwaysBundle covers the file-type transitive closure', () => {
const fileTypeClosure = [
'@borewit/text-codec',
'@tokenizer/inflate',
'@tokenizer/token',
'file-type',
'ieee754',
'strtok3',
'token-types',
'uint8array-extras',
];

for (const dep of fileTypeClosure) {
test(`alwaysBundle covers transitive dep '${dep}'`, () => {
const escaped = dep.replace(/[\\^$*+?.()|[\]{}-]/g, '\\$&').replace(/\//g, '\\\\?/');
const pattern = new RegExp(`\\^${escaped}\\(`);
expect(
pattern.test(alwaysBundleBlock),
`Add /^${dep}(\\/|$)/ to packages/cli/tsdown.config.ts \`alwaysBundle\`. ` +
`It is a pure-JS transitive dep of file-type (the server's upload ` +
`MIME-sniff); externalized, it leaves a bare \`import '${dep}'\` that ` +
`crashes packaged-app uploads with ERR_MODULE_NOT_FOUND.`,
).toBe(true);
});
}
});
8 changes: 8 additions & 0 deletions packages/cli/tsdown.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,13 @@ export default defineConfig({
/^@octokit\/auth-oauth-device(\/|$)/,
/^@octokit\/request(\/|$)/,
/^@octokit\/rest(\/|$)/,
/^@borewit\/text-codec(\/|$)/,
/^@tokenizer\/inflate(\/|$)/,
/^@tokenizer\/token(\/|$)/,
/^cli-boxes(\/|$)/,
/^commander(\/|$)/,
/^file-type(\/|$)/,
/^ieee754(\/|$)/,
/^jsonc-parser(\/|$)/,
/^just-bash(\/|$)/,
/^picocolors(\/|$)/,
Expand All @@ -75,6 +80,9 @@ export default defineConfig({
/^simple-git(\/|$)/,
/^sirv(\/|$)/,
/^smol-toml(\/|$)/,
/^strtok3(\/|$)/,
/^token-types(\/|$)/,
/^uint8array-extras(\/|$)/,
/^yaml(\/|$)/,
/^yazl(\/|$)/,
/^zod(\/|$)/,
Expand Down
9 changes: 5 additions & 4 deletions packages/server/src/api-extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ import {
resolveGitDirDetailed,
} from '@inkeep/open-knowledge-core/shadow-repo-layout';
import busboy from 'busboy';
import { fileTypeFromFile } from 'file-type';
import { fileTypeFromBuffer } from 'file-type';
import { parse as parseYaml } from 'yaml';
import { z } from 'zod';
import { captureEffect } from './activity-log.ts';
Expand Down Expand Up @@ -8318,12 +8318,13 @@ export function createApiExtension(options: ApiExtensionOptions): Extension {
}
}

const fileTypeResult = await fileTypeFromFile(tempPath);
const SNIFF_HEAD_BYTES = 4100;
const head = readTempFileHead(tempPath, SNIFF_HEAD_BYTES);
const fileTypeResult = await fileTypeFromBuffer(head);
let detectedMime: string | undefined = fileTypeResult?.mime;
let detectedExt: string | undefined = fileTypeResult?.ext;
if (!detectedMime) {
const head = readTempFileHead(tempPath, 256);
const headText = head.toString('utf-8').replace(/^/, '').trimStart();
const headText = head.subarray(0, 256).toString('utf-8').replace(/^/, '').trimStart();
if (
headText.startsWith('<svg') ||
(headText.startsWith('<?xml') && headText.includes('<svg'))
Expand Down