Add a project setting for attachment upload placement, including…#391
Merged
Conversation
* feat(open-knowledge): add attachment folder setting * i18n * fix(open-knowledge): move attachment settings into preferences * fix(open-knowledge): address attachment review feedback * i18n * fix(open-knowledge): refine attachment review fixes * fix(open-knowledge): stabilize attachment settings tests * test(open-knowledge): cover attachment validation rejection GitOrigin-RevId: e01af541abf0dcdd8a6e4270e0201a063e6fe747
…) (#2249)
* docs(open-knowledge): add "Using with Obsidian" vault guide (PRD-7172)
New get-started page for people coming from Obsidian: how to open an
existing vault (desktop + CLI), which Obsidian markdown syntax carries
over (wiki links, callouts, tags, frontmatter, math, mermaid, comments,
highlights, footnotes, asset embeds), where the two differ (note
transclusion, block references, `.obsidian/`, community plugins,
Canvas/Bases), and how OpenKnowledge's built-in agent skills compare to
adding an agent-skills layer onto Obsidian.
Registered in the get-started nav after Quickstart.
* docs(open-knowledge): address review feedback on Obsidian guide
- Add `ok-flush-tabs` to the Tabs so nested <Steps> don't double the
left rail (matches quickstart; the class exists for exactly this).
- Move the concurrent-editing caution above the setup steps so it's
seen before a reader opens both apps.
- Reframe the note-transclusion row: the wiki link still navigates.
- Drop the imprecise `ok skills manage` reference (it's an adoption
opt-in toggle, not a skill-browsing command) — skills are just docs.
- Add Editor and Timeline & recovery to "See also" (both referenced in
the body).
* docs(open-knowledge): align Obsidian guide with docs conventions
- Add a Prerequisites callout (Node.js 24+, git) to the web-app/CLI
tab, matching the quickstart pattern.
- Switch the "See also" list to the colon separator used by the other
See-also sections (editor, ignore-patterns, folders-and-templates).
* docs(open-knowledge): simplify "Open your vault" — drop tabs and co-edit caution
- Replace the macOS/web-app Tabs with two plain subsections (Desktop app
/ CLI); the tab toggle added friction without changing the content.
- Remove the concurrent-editing warning callout.
* docs(open-knowledge): trim "Open your vault" to one platform-neutral step
- Drop the "Initialize the knowledge base" step.
- Remove the macOS label — the Create-new-project flow is the same on
every platform.
- Remove the CLI section (and its prerequisites callout).
* docs(open-knowledge): correct vault-open flow to "Open folder on disk"
Use the actual entry point ("Open folder on disk" → select folder →
Setup screen) instead of "Create new project" + Browse.
* docs(open-knowledge): add cross-platform path to "Open your vault"
"Open folder on disk" + the Setup screen is the macOS desktop app only
(the Project Navigator never renders in the web/CLI distribution). Add a
one-line CLI path (ok init && ok start --open) so Linux/Windows/Intel Mac
users have a way in. Also smooth the page description to parallel phrasing.
* docs(open-knowledge): tighten Obsidian guide
Split "Open your vault" into per-platform subsections (macOS desktop /
CLI) and trim the intro and agent-skills section.
---------
GitOrigin-RevId: c55aa300a9e9bfe088a6fab87780d233afa040da
![inkeep-internal-ci[bot]](https://avatars.githubusercontent.com/in/2806322?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated approval from agents-private public-mirror-sync (run: https://github.com/inkeep/agents-private/actions/runs/28460282099). Source of truth is the monorepo; direct edits on inkeep/open-knowledge are overwritten on next sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a project setting for attachment upload placement, including Settings controls and upload routing for content-root and current-folder attachment directories.