fix(open-knowledge): guard auto-promote against already-released + half-cut betas#330
Merged
Conversation
…lf-cut betas (#2199) The repository_dispatch auto-resolve picks the newest vX.Y.Z-beta.N tag, but a tag exists minutes before its release is complete (release.yml creates the GH Release as a draft; desktop-release.yml flips it to published only after the signed DMG + beta-mac.yml upload, on a separate concurrency group). The newest tag can also already be promoted, since it keeps pointing at the just-released version until a new beta is cut. Add two guards on the auto path only (explicit beta_tag keeps its idempotent recovery behavior): - Guard A: refuse if the derived stable vX.Y.Z tag already exists. - Guard B: refuse unless the beta's GH Release is published (not draft) with a .dmg and a -mac.yml asset. Both fail loud with actionable messages so a Slack-triggered promotion surfaces why it stopped instead of shipping a broken stable. GitOrigin-RevId: 723d1adfcf807e58f7b0fae971148a4da80abd78
Contributor
There was a problem hiding this comment.
Automated approval from agents-private public-mirror-sync (run: https://github.com/inkeep/agents-private/actions/runs/28253987231). Source of truth is the monorepo; direct edits on inkeep/open-knowledge are overwritten on next sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.