Fix the bottom "Ask AI" composer dropping the typed instruction when…#299
Merged
Conversation
…unch (#2156) The bottom Ask AI composer carries its typed instruction in input.compose, but composeTerminalLaunchPrompt only checked the top-level input.instruction used by the toolbar popover. Composer dispatches to a Terminal CLI therefore fell through to the bare load-and-stop prompt and silently dropped the user's message, so the launched CLI never saw what the user asked. Route compose-scope inputs through selectScopedPrompt (which already threads input.compose through assembleHandoffPrompt) so the instruction reaches the launched CLI exactly as it does the deep-link handoff. Adds a regression test pinning the compose-scope launch to selectScopedPrompt. GitOrigin-RevId: 45cb9ec04a0e878d0667096b1de89298ec488f48
![inkeep-internal-ci[bot]](https://avatars.githubusercontent.com/in/2806322?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated approval from agents-private public-mirror-sync (run: https://github.com/inkeep/agents-private/actions/runs/28210573453). Source of truth is the monorepo; direct edits on inkeep/open-knowledge are overwritten on next sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the bottom "Ask AI" composer dropping the typed instruction when launching a Terminal CLI. A composer dispatch carries its instruction (and
@-mentions / selection) ininput.compose, but the docked-terminal launcher only checked the top-levelinput.instructionthe toolbar popover uses — so every composer-typed message fell through to the bare "load OK, then stop" prompt and the agent never saw what the user asked. The terminal launcher now routes compose-scope dispatches through the same prompt assembler as the deep-link handoff, so the instruction threads through to the launched CLI exactly as it does to a Claude/Codex/Cursor deep link.