fix(open-knowledge): truncate the Ask AI selection chip label#279
Merged
Conversation
The selection pill's label is a shadcn Button whose base `shrink-0` +
`whitespace-nowrap` left the inline-flex button at its content width inside
the pill's max-w-[16rem] span — so a long file name overflowed the chip's
border (measured 275px content vs the 256px capped span). Add `shrink` to
let the button shrink and move `truncate` to an inner span so the label
ellipsizes within the cap, matching the file chip. Add `title={pinnedLabel}`
so the full label stays recoverable on hover / AT once truncated.
GitOrigin-RevId: 9084deb00ed3eef00e695fa0e72e1b2dc66cf306
Contributor
There was a problem hiding this comment.
Automated approval from agents-private public-mirror-sync (run: https://github.com/inkeep/agents-private/actions/runs/28197759273). Source of truth is the monorepo; direct edits on inkeep/open-knowledge are overwritten on next sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.