Dev: set OK_INSTANCE=<name> to run multiple desktop dev instances in…#274
Merged
Conversation
Electron keys its single-instance lock on the userData directory, so a second electron-vite dev process fails requestSingleInstanceLock() and quits. Setting OK_INSTANCE=<name> on an unpackaged build relocates that launch's userData to a named sibling directory, giving each instance its own lock plus isolated Chromium storage and recents so two builds run side by side. Packaged releases ignore it. Adds the pure deriveInstanceUserDataDir/sanitizeInstanceName helper with unit tests, wires it before requestSingleInstanceLock(), passes OK_INSTANCE through Turbo's strict env filter, and documents the workflow in the desktop README. GitOrigin-RevId: 45234d6e4d2840f1c3248130cf70124e0b3037a7
![inkeep-internal-ci[bot]](https://avatars.githubusercontent.com/in/2806322?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated approval from agents-private public-mirror-sync (run: https://github.com/inkeep/agents-private/actions/runs/28195100168). Source of truth is the monorepo; direct edits on inkeep/open-knowledge are overwritten on next sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dev: set
OK_INSTANCE=<name>to run multiple desktop dev instances in parallel. Electron keys its single-instance lock on theuserDatadirectory, so twoelectron-vite devprocesses normally collide and the second quits.OK_INSTANCErelocates each launch'suserDatato a named sibling directory (Open Knowledge (<name>)), giving every instance its own lock and its own isolated Chromium storage and recents. Honored only on unpackaged builds; packaged releases are unaffected.