The integrated terminal now opens at about one third of the window…#272
Merged
Conversation
* Open terminal dock at ~1/3 of window height on first use The integrated terminal opened at a fixed 240px, too short to read a command's output without dragging the divider. Compute the first-open height as ~1/3 of the editor viewport instead, so it scales with window size while still respecting the 120px floor and 50vh ceiling. A height set by dragging is still remembered. * Address local review feedback on terminal dock height - Pin the ~1/3 default with a literal (333) instead of a fraction-derived value so a regression to the fraction is actually caught; add a short-viewport case covering the new fraction-below-floor composition. - Make DEFAULT_TERMINAL_HEIGHT_FRACTION module-private (was exported only for the test). - Correct header comments: the fixed-px fallback is for no-window hosts, not storage-restricted ones (those hit the catch); the default scales with the renderer window, not the editor pane. Document the catch's intentional fixed-px fallback. GitOrigin-RevId: c1ee22f14f2f5a321964c2b2f64063ffe4be8881
![inkeep-internal-ci[bot]](https://avatars.githubusercontent.com/in/2806322?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated approval from agents-private public-mirror-sync (run: https://github.com/inkeep/agents-private/actions/runs/28192993040). Source of truth is the monorepo; direct edits on inkeep/open-knowledge are overwritten on next sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integrated terminal now opens at about one third of the window height on first use, instead of a fixed 240px that was often too short to read a command's output without dragging the divider. The default is computed as a fraction of the window height (so it scales with window size) and still respects the existing 120px floor and 50vh ceiling. A height you set by dragging is remembered as before.