Added sets: Mantle of Siroria, Domihaus, Winter's Respite#25
Open
Hacktank wants to merge 6 commits into
Open
Conversation
Perfected/Normal Void Bash (Vatashran shield) Tremorscale Sentinel of Rkugamz Perfected Claw of Yolnakriin Added a new global option to disable all audio notifications.
… has run it's course. This is a work-around for an ESO bug with the stone-talker set where the timer ID 154786 was being reapplied whenever anyone performed a heavy attack on the affected enemy.
inimicus
requested changes
Dec 27, 2023
inimicus
left a comment
inimicus
left a comment
Owner
There was a problem hiding this comment.
Thank you for this! Some notes, comments, and conflicts needing to be addressed. Appreciate it!
❤️
| Cool = Cool or {} | ||
| Cool.name = "Cooldowns" | ||
| Cool.version = "1.7.0" | ||
| Cool.version = "1.8.0" |
Owner
There was a problem hiding this comment.
As v1.7.0 is still in dev, no need to bump the version yet.
| if result == ACTION_RESULT_ABILITY_ON_COOLDOWN then | ||
| Cool:Trace(1, "<<1>> (<<2>>) on Cooldown", abilityName, abilityId) | ||
| elseif result == set.result then | ||
| elseif result == set.result and not set.onCooldown then |
Owner
There was a problem hiding this comment.
Good addition. Makes me even more sad that ACTION_RESULT_ABILITY_ON_COOLDOWN is no longer in the game.
| label:SetText("") | ||
| texture:SetColor(1, 1, 1, 1) | ||
| Cool.UI.PlaySound(Cool.preferences.sets[setKey].sounds.onReady) | ||
| if Cool.preferences.audioNotifications then Cool.UI.PlaySound(Cool.preferences.sets[setKey].sounds.onReady) end |
Owner
There was a problem hiding this comment.
What do you think about moving the condition to check for audioNotifications moving to inside Cool.UI.Playsound?
e.g.
function Cool.UI.PlaySound(sound)
if sound.enabled and Cool.preferences.audioNotifications then
PlaySound(SOUNDS[sound.sound])
end
end
| gridSize = 16, | ||
| showOutsideCombat = true, | ||
| lagCompensation = true, | ||
| audioNotifications = true, |
| [577] = { | ||
| procType = "set", | ||
| event = EVENT_COMBAT_EVENT, | ||
| description = "Displays when the Sentinel of Rkugamz proc is available or cooldown until it is ready again.", |
Owner
There was a problem hiding this comment.
Is this description text correct?
| id = 97855, | ||
| result = ACTION_RESULT_EFFECT_GAINED, | ||
| cooldownDurationMs = 35000, | ||
| cooldownDurationMs = 20000, |
inimicus
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.