feat(standards): MintNote bon builder#13
Closed
VAIBHAVJINDAL3012 wants to merge 1 commit into
Closed
Conversation
Convert the `MintNote` marker type into a struct built via a `bon` typestate builder (`MintNote::builder()`), mirroring `P2idNote`. A `MintNote` converts into a `Note` via `Note::from` and keeps the faucet-id/asset-faucet match check via `NoteError::other`. Migrate the faucet mint-note test sites. Part of 0xMiden#2283.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| faucet.id(), | ||
| faucet_owner_account_id, | ||
| mint_storage, | ||
| NoteAttachments::default(), |
Author
There was a problem hiding this comment.
default and not putting attachment are different ruight???
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts
MintNotefrom a unit marker +MintNote::createfactory into a struct built with abontypestate builder (MintNote::builder()), mirroring the mergedP2idNotebuilder. One of three per-note PRs splitting the standard-note builder work (Swap / Burn / Mint).MintNote::builder()produces aMintNotethat converts into aNoteviaNote::from(always public, no assets - the minted asset lives in storage).NoteError::other.Builder-only change; no MASM or on-chain behaviour changes.
Verification
cargo clippy -p miden-standards -p miden-testing --all-targets --all-features -- -D warnings- cleannote::mint::tests::{builder_builds_public_mint_note, builder_rejects_mismatched_faucet}unit tests; the faucet mint suites pass and re-run in CI here.