Skip to content

feat(standards): BurnNote bon builder#12

Closed
VAIBHAVJINDAL3012 wants to merge 1 commit into
nextfrom
vaibhav/burn-note-builder
Closed

feat(standards): BurnNote bon builder#12
VAIBHAVJINDAL3012 wants to merge 1 commit into
nextfrom
vaibhav/burn-note-builder

Conversation

@VAIBHAVJINDAL3012

@VAIBHAVJINDAL3012 VAIBHAVJINDAL3012 commented Jun 25, 2026

Copy link
Copy Markdown

Summary

Converts BurnNote from a unit marker + BurnNote::create factory into a struct built with a bon typestate builder (BurnNote::builder()), mirroring the merged P2idNote builder. One of three per-note PRs splitting the standard-note builder work (Swap / Burn / Mint).

  • BurnNote::builder() produces a BurnNote that converts into a Note via Note::from (always public, tagged for the faucet).
  • Migrated the 6 faucet burn-note test sites.

Builder-only change; no MASM or on-chain behaviour changes.

Verification

  • cargo clippy -p miden-standards -p miden-testing --all-targets --all-features -- -D warnings - clean
  • New note::burn::tests::builder_builds_public_burn_note unit test; the faucet burn suites pass and re-run in CI here.

Convert the `BurnNote` marker type into a struct built via a `bon` typestate
builder (`BurnNote::builder()`), mirroring `P2idNote`. A `BurnNote` converts
into a `Note` via `Note::from`. Migrate the faucet burn-note test sites.

Part of 0xMiden#2283.
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ae86e3a1-9744-4ec2-8ba0-0a599bb04996

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch vaibhav/burn-note-builder

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant