🎨 Palette: Ignore clicks on empty placeholder rows in Treeviews#32
🎨 Palette: Ignore clicks on empty placeholder rows in Treeviews#32inherent-vice wants to merge 1 commit into
Conversation
…reeview In the CustomTkinter Treeview implementation, empty state rows are added using `iid="__empty__"` or `iid="__idle__"`. Clicking on these placeholder items would previously cause visual feedback or trigger internal logic since they did not match actual items. This commits adds a fast fail UX pattern to ignore events when these placeholder items are clicked. Also records this UX pattern in the Palette journal at `.Jules/palette.md`. Co-authored-by: agno7766 <125467265+agno7766@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Your plan includes 1 review of capacity. Refill in 59 minutes and 25 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
💡 What
Modified
select_excel_file_from_event,open_excel_file_from_event,toggle_file_selection,select_running_excel_from_eventandtoggle_excel_selectionto explicitly check if the clicked row is__empty__or__idle__and exit early if true.🎯 Why
This solves a UX annoyance where clicking the "No items found" empty placeholder row in the Treeview would trigger internal logic or state changes that shouldn't apply, since the row is an informational placeholder and not a valid entity to select or open.
♿ Accessibility
Improves interaction robustness by ignoring click interactions on non-interactive placeholder empty states in the Treeview components.
PR created automatically by Jules for task 8672654135686783204 started by @agno7766