⚡ Bolt: Optimize psutil process iteration to lazily fetch expensive attributes#21
⚡ Bolt: Optimize psutil process iteration to lazily fetch expensive attributes#21inherent-vice wants to merge 1 commit into
Conversation
Optimize psutil.process_iter to lazily fetch expensive attributes. - Modifies desktop_services/excel_service.py and desktop_services/operations_cockpit_service.py to query only `["pid", "name"]` in `psutil.process_iter()`. - Expensive attributes `memory_info()` and `status()` are lazily fetched only for 'excel.exe' processes, wrapped in safety try/except blocks. - Adds a performance learning journal entry to `.jules/bolt.md`. Co-authored-by: agno7766 <125467265+agno7766@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1b06ec6726
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| status = proc.status() | ||
| except (psutil.NoSuchProcess, psutil.AccessDenied, psutil.ZombieProcess, AttributeError): | ||
| status = "running" |
There was a problem hiding this comment.
When proc.status() raises NoSuchProcess/ZombieProcess, this code now falls back to "running" and still records the PID. That creates ghost Excel entries when a process exits between proc.info and the lazy attribute reads, so get_running_instances() can briefly report non-existent sessions with 0.0 MB memory. Previously, a process disappearing during the scan path was skipped by the outer exception handling.
Useful? React with 👍 / 👎.
| status = proc.status() | ||
| except (psutil.NoSuchProcess, psutil.AccessDenied, psutil.ZombieProcess, AttributeError): | ||
| status = "running" |
There was a problem hiding this comment.
In the cockpit guard, NoSuchProcess/ZombieProcess during lazy status() lookup is converted to "running" and appended anyway. If Excel exits during iteration, _default_processes() can emit stale rows, inflating running_count and downstream risk summaries for that polling cycle. This should skip terminated processes instead of coercing them to running.
Useful? React with 👍 / 👎.
1 participant
💡 What:
Optimizes the way system processes are scanned. Instead of querying expensive attributes (
memory_info,status) for all processes upfront duringpsutil.process_iter(["pid", "name", "memory_info", "status"]), the codebase now queries only["pid", "name"]. The expensive attributes are then lazily fetched via individual method calls (proc.memory_info(),proc.status()) only if the process is identified as the target ('excel.exe').🎯 Why:
Querying expensive attributes like
memory_infoacross all processes is a known performance bottleneck inpsutil, especially on Windows. Since the application frequently scans for Excel processes to monitor active sessions, fetching these attributes for hundreds of irrelevant background system processes adds significant overhead. Filtering by process name first mitigates this.📊 Impact:
Expected to significantly reduce the overhead of periodic Excel session monitoring, decreasing CPU spikes and wait times when the application refreshes process snapshots.
🔬 Measurement:
This can be verified by profiling the execution time of
ExcelDesktopService._get_excel_process_snapshots()andExcelSessionGuard.snapshot()before and after the change on a system with a large number of background processes running.PR created automatically by Jules for task 1939126394544168307 started by @agno7766