Skip to content

matching stats as join table#3835

Open
awildturtok wants to merge 68 commits into
developfrom
feature/matching-stats-as-join-table
Open

matching stats as join table#3835
awildturtok wants to merge 68 commits into
developfrom
feature/matching-stats-as-join-table

Conversation

@awildturtok

@awildturtok awildturtok commented Jan 22, 2026

Copy link
Copy Markdown
Collaborator

Eine Beispielhafte join-table könnte folgende Einträge enthalten:

                     resolved_id                      | col_val
------------------------------------------------------+----------
 database.icd.s00-t98.s00-s09.s00.s00_0.s00_00 | T612
 database.icd.s00-t98.s00-s09.s00.s00_0.s00_00 | T611
 database.icd.s00-t98.s00-s09.s00.s00_0.s00_00 | T610
 database.icd.j00-j99.j30-j39.j38.j38_0.j38_00 | J951
  select
    diag.id as "pid",
    least(
      'infinity'::date,
      lower("datum"),
      upper("datum")
    ) as "lower_bound",
    greatest(
      '-infinity'::date,
      lower("datum"),
      upper("datum")
    ) as "upper_bound",
    "resolved_id"
  from "diag"
    left outer join "icd_ids"
      on "diag"."icd_code" = "col_val"

im Falle von ColumnEquals wären dann noch weitere Spalten dabei. Bei PRESENT/EMPTY wären stattdessen true/false drin, die dann im join abgebildet werden.

awildturtok and others added 30 commits November 12, 2025 15:24
# Conflicts:
#	backend/src/main/java/com/bakdata/conquery/mode/local/LocalStorageListener.java
Also fixes a case, where missing entries were not registered to the root.
…tats-as-sql-function

# Conflicts:
#	backend/src/main/java/com/bakdata/conquery/models/messages/namespaces/specific/UpdateMatchingStatsMessage.java
@awildturtok awildturtok requested a review from thoniTUB April 9, 2026 10:00
@awildturtok awildturtok disabled auto-merge April 9, 2026 10:02
@awildturtok awildturtok disabled auto-merge April 9, 2026 10:02
Comment thread backend/src/main/java/com/bakdata/conquery/mode/local/ManagedConnection.java Outdated
Comment on lines +19 to +20
@Data
public abstract class StorageListener<T extends Namespace>{

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich hatte glaube ich gehofft mehr logik zu vereinheitlichen, bin auch nicht deiner Meinung. Aber hier ist es definitiv die klasse wert.

Comment thread backend/src/main/java/com/bakdata/conquery/sql/conquery/SqlMatchingStats.java Outdated

@thoniTUB thoniTUB left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich muss nochmal weiter machen.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Würde ich behalten

Comment thread backend/src/main/java/com/bakdata/conquery/sql/conquery/SqlMatchingStats.java Outdated
Comment thread backend/src/main/java/com/bakdata/conquery/sql/conquery/SqlMatchingStats.java Outdated
Comment thread backend/src/main/java/com/bakdata/conquery/sql/conquery/SqlMatchingStats.java Outdated
Comment thread backend/src/test/resources/tests/sql/tree/nested/nested.spec.json
@awildturtok awildturtok force-pushed the feature/matching-stats-as-join-table branch from 37845a2 to ec0a4cb Compare April 20, 2026 15:08
@awildturtok awildturtok requested a review from thoniTUB April 21, 2026 08:18
Comment thread backend/src/test/resources/EXCLUDED_sql/combined/combined.test.json
@@ -1,7 +1,7 @@
{
"type": "QUERY_TEST",
"sqlSpec": {
"isEnabled": true
"isEnabled": false

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wieder enablen?

Comment thread backend/src/test/resources/EXCLUDED_sql/tree/nested/nested.test.json Outdated
Comment thread backend/src/test/resources/EXCLUDED_sql/tree/prefix_range/prefix_range.test.json Outdated
@@ -1,7 +1,7 @@
{
"type": "QUERY_TEST",
"sqlSpec": {
"isEnabled": true
"isEnabled": false

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enabled?

Taking the short example from above, we want to explain how we do this using the
[AnsiSqlIntervalPacker](./AnsiSqlIntervalPacker.java). To outline, we need to
create 3 consecutive common table expressions (CTE):
create 3 consecutive common table conceptConditions (CTE):

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
create 3 consecutive common table conceptConditions (CTE):
create 3 consecutive common table expressions (CTE):

awildturtok and others added 2 commits June 2, 2026 16:24
# Conflicts:
#	backend/src/main/java/com/bakdata/conquery/sql/conversion/cqelement/CQExternalConverter.java
#	backend/src/main/java/com/bakdata/conquery/sql/conversion/cqelement/CQYesConverter.java
#	backend/src/main/java/com/bakdata/conquery/sql/conversion/cqelement/concept/CQConceptConverter.java
#	backend/src/main/java/com/bakdata/conquery/sql/conversion/dialect/SqlFunctionProvider.java
#	backend/src/main/java/com/bakdata/conquery/sql/conversion/dialect/hana/HanaSqlFunctionProvider.java
#	backend/src/main/java/com/bakdata/conquery/sql/conversion/dialect/pg/PostgreSqlFunctionProvider.java
#	backend/src/main/java/com/bakdata/conquery/sql/conversion/forms/AbsoluteStratification.java
#	backend/src/main/java/com/bakdata/conquery/sql/conversion/model/ColumnDateRange.java
#	backend/src/main/java/com/bakdata/conquery/sql/conversion/model/SqlIdColumns.java
#	backend/src/main/java/com/bakdata/conquery/sql/conversion/model/StratificationSqlIdColumns.java
#	backend/src/main/java/com/bakdata/conquery/util/TablePrimaryColumnUtil.java
#	backend/src/test/java/com/bakdata/conquery/integration/json/SqlTestDataImporter.java
@awildturtok awildturtok force-pushed the feature/matching-stats-as-join-table branch from 402d93d to 5f7fdee Compare June 4, 2026 12:50
Comment thread backend/src/main/java/com/bakdata/conquery/sql/conquery/SqlMatchingStats.java Outdated
Comment thread backend/src/main/java/com/bakdata/conquery/sql/conquery/SqlMatchingStats.java Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants