Skip to content

[FIX] stock_batch_picking_ux: reset quantities to zero only on reception batches#956

Open
fw-bot-adhoc wants to merge 1 commit into
ingadhoc:19.0from
adhoc-dev:19.0-18.0-h-120763-les-6583-fw
Open

[FIX] stock_batch_picking_ux: reset quantities to zero only on reception batches#956
fw-bot-adhoc wants to merge 1 commit into
ingadhoc:19.0from
adhoc-dev:19.0-18.0-h-120763-les-6583-fw

Conversation

@fw-bot-adhoc

Copy link
Copy Markdown
Contributor

Problema (ticket 120763)

Al armar olas/entregas (pickings de salida) agrupando pedidos en un stock.picking.batch, los pedidos quedaban con disponibilidad 0 y pasaban de "a procesar" a "en espera", bloqueando el pickeo.

Causa

El override de action_confirm() agregado en la tarea 68226 (RF-02) reseteaba quantity = 0 en todas las líneas del batch al confirmar. Esa inicialización en cero estaba pensada solo para recepciones parciales (RF-02 original: "Inicialización de Cantidades en Cero para Recepciones Parciales"), pero se aplicaba también a entregas y movimientos internos, quitándoles la cantidad reservada.

Fix

Restringir el reseteo a líneas de pickings de recepción (picking_type_id.code == 'incoming'). Entregas/olas y movimientos internos ya no se tocan.

Cómo probar

  • Armar una ola de entregas con pedidos disponibles → confirmar el batch → la disponibilidad se mantiene (ya no va a 0).
  • Armar un batch de recepción parcial → confirmar → sigue inicializando en 0 (comportamiento RF-02 intacto).

Relacionado: tarea 68226 (desarrollo original), PR #940 (ya mergeado).

Forward-Port-Of: #954

…ion batches

The action_confirm override zeroed the quantity of every operation line in
the batch, which on deliveries/waves (outgoing pickings) wrongly removed the
product availability and pushed orders to 'waiting'. The zeroing was meant
only for partial receptions (task 68226 RF-02), so restrict it to incoming
pickings.

Ticket 120763

X-original-commit: 22aafbe
@roboadhoc

Copy link
Copy Markdown
Collaborator

Pull request status dashboard

@fw-bot-adhoc

Copy link
Copy Markdown
Contributor Author

@les-adhoc @mav-adhoc cherrypicking of pull request #954 failed.

stdout:

Auto-merging stock_batch_picking_ux/__manifest__.py
CONFLICT (content): Merge conflict in stock_batch_picking_ux/__manifest__.py
Auto-merging stock_batch_picking_ux/models/stock_batch_picking.py
CONFLICT (content): Merge conflict in stock_batch_picking_ux/models/stock_batch_picking.py

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

:shipit: you can use git-fw to re-do the forward-port for you locally.

⚠️ after resolving this conflict, you will need to merge it via @roboadhoc.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants