Rewind rack.input in Base before reading request body for Rack 3 support#73
Merged
Conversation
gogi1805
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rack 3 support
Resolves: #72
Summary
Fixes missing JSON, plain text, and XML
requestBodyexamples in generated docs, and aNoMethodErroron bodyless requests, when running the dox formatter against request specs on Rails apps using Rack 3.Problem
Rack 3 dropped the implicit rewind on
Rack::Request#body.Dox::Formatters::Multipartwas fixed in v3.0.1 (#71), butJson,Plain, andXmlstill inherit fromFormatters::Base, which reads the request body without rewinding first.By the time the formatter runs, Rails has already consumed the body during request processing, so
http_env.body.readreturns"". For JSON requests this silently omitsrequestBodyexamples from the generated spec. For bodyless requests, Rack 3 returnsnilinstead ofStringIO(""), which causesFormatters::Plainto raiseNoMethodErroronbody.encoding.Test plan
bundle exec rspec spec/formatters/bundle exec rspec