ID-163: update sidekiq#793
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #793 +/- ##
=======================================
Coverage 89.79% 89.79%
=======================================
Files 291 291
Lines 8365 8365
Branches 2004 2002 -2
=======================================
Hits 7511 7511
Misses 799 799
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ljtucker
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, downstream test kits, such as the Da Vinci CRD Test Kit, were allowed to and were using version 3 of the connection_pool gem, which was incompatible with version 7.2.4 of the sidekiq gem. This caused a warning when starting up inferno related to the
popmethod, e.g.,Functionally, this didn't have any impact on normal Inferno operation because normal job execution still works, but could potentially prevent automatic retries because the scheduler thread gets killed due to the error.
Now, the inferno_core gem relies on sidekiq v7.3.10 which caps the version of connection_pool at 2.X. This upper bound prevents the incompatible versions from being installed together and eliminates this startup error.
Testing Guidance
Test using the CRD test kit, which is where the issue was observed
inferno_coregem from the checked out directory, e.g., throughgem 'inferno_core', path: '../inferno-core'. Run bundle. Stop and re-start the background services and start inferno again. Observe that the above error does not occur and theclass=Inferno::Jobs::InvokeValidatorSessionjob starts and stops without errors indicated in the inferno logs