Skip to content

ID-163: update sidekiq#793

Merged
karlnaden merged 3 commits into
mainfrom
sidekiq-fix
Jun 18, 2026
Merged

ID-163: update sidekiq#793
karlnaden merged 3 commits into
mainfrom
sidekiq-fix

Conversation

@karlnaden

Copy link
Copy Markdown
Contributor

Summary

Previously, downstream test kits, such as the Da Vinci CRD Test Kit, were allowed to and were using version 3 of the connection_pool gem, which was incompatible with version 7.2.4 of the sidekiq gem. This caused a warning when starting up inferno related to the pop method, e.g.,

22:55:26 worker.1 | 2026-06-18T02:55:26.127Z pid=78057 tid=1lzp WARN: ArgumentError: wrong number of arguments (given 1, expected 0)
22:55:26 worker.1 | 2026-06-18T02:55:26.127Z pid=78057 tid=1lzp WARN: /Users/karlnaden/.asdf/installs/ruby/3.3.6/lib/ruby/gems/3.3.0/gems/connection_pool-3.0.2/lib/connection_pool/timed_stack.rb:62:in `pop'

Functionally, this didn't have any impact on normal Inferno operation because normal job execution still works, but could potentially prevent automatic retries because the scheduler thread gets killed due to the error.

Now, the inferno_core gem relies on sidekiq v7.3.10 which caps the version of connection_pool at 2.X. This upper bound prevents the incompatible versions from being installed together and eliminates this startup error.

Testing Guidance

Test using the CRD test kit, which is where the issue was observed

  1. Check out the CRD test kit main branch, start the background services, and start inferno. Observe that the above error appears in the inferno logs.
  2. Check out this branch of inferno-core and run bundle install. In the CRD test kit GemFIle, reference the inferno_core gem from the checked out directory, e.g., through gem 'inferno_core', path: '../inferno-core'. Run bundle. Stop and re-start the background services and start inferno again. Observe that the above error does not occur and the class=Inferno::Jobs::InvokeValidatorSession job starts and stops without errors indicated in the inferno logs
  3. Run the CRD client suite against the server suite using these instructions (can just do the order-sign hook) and confirm that the tests work as expected including validator calls working (there will be some warm-up time) and tests re-starting after wait dialogs.

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.79%. Comparing base (305a21d) to head (05f699d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #793   +/-   ##
=======================================
  Coverage   89.79%   89.79%           
=======================================
  Files         291      291           
  Lines        8365     8365           
  Branches     2004     2002    -2     
=======================================
  Hits         7511     7511           
  Misses        799      799           
  Partials       55       55           
Flag Coverage Δ
backend 92.50% <ø> (ø)
frontend 83.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@karlnaden karlnaden merged commit 9dbe6b7 into main Jun 18, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants