Replace outdated rest-client with httprb and update oauth2 dependency #160
Open
stevenjcumming wants to merge 3 commits into
Open
Replace outdated rest-client with httprb and update oauth2 dependency #160stevenjcumming wants to merge 3 commits into
stevenjcumming wants to merge 3 commits into
Conversation
| # @return | ||
| # | ||
| def initialize(base_service_url, default_format: FHIR::Formats::ResourceFormat::RESOURCE_JSON, proxy: nil) | ||
| base_service_url = "http://#{base_service_url}" unless base_service_url.start_with?("https://", "http://") |
There was a problem hiding this comment.
Instead of dealing with these URLS as strings to be manipulated and mutated, what do you think about using the ruby URI object?
uri = URI.parse(base_service_url)
# Check if the scheme is missing
if uri.scheme.nil?
# Construct a new URI with the "http" scheme
uri = URI::HTTP.build(host: uri.host, path: uri.path)
end
@base_service_url = uri
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rest-clienthttprb