Skip to content

FQM-334: Fix response validation tests#123

Merged
karlnaden merged 22 commits into
mainfrom
fqm-334-fix-response-validation-tests
Jul 8, 2026
Merged

FQM-334: Fix response validation tests#123
karlnaden merged 22 commits into
mainfrom
fqm-334-fix-response-validation-tests

Conversation

@Jammjammjamm

@Jammjammjamm Jammjammjamm commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

This branch removes the old response validation from the 2.2.1 server suite and fully transitions the response validation tests to rely on the logical models validation.

  • Cards optional fields validation test removed
  • Service response validation test validates the response against the base response logical model
  • Individual response type tests find relevant responses and validate them against the particular logical model for that response type

Testing Guidance

The hooks tests should still pass when run against the client suite. The Specific Coverage Responses tests will still fail.

Anticipated Provider-side Test Impact

This update required two minor fixes to the mocked responses in the client suite:

  • The suggestion was removed from the mock smart app launch card to align with the spec's intention
  • A bug in the coverage information configuration handling was fixed. Previously, the response could contain an empty array in the systemActions field, which is not allowed in the spec, so this was changed to ensure that the systemActions field is removed if there are no actions.

@Jammjammjamm Jammjammjamm self-assigned this Jul 1, 2026
@Jammjammjamm Jammjammjamm force-pushed the fqm-334-fix-response-validation-tests branch from 1f9da05 to cff3057 Compare July 1, 2026 15:37
@Jammjammjamm Jammjammjamm changed the title WIP FQM-334: Fix response validation tests FQM-334: Fix response validation tests Jul 1, 2026
@Jammjammjamm Jammjammjamm requested review from arscan and tstrass July 1, 2026 15:45

@tstrass tstrass left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't been able to test it today due to terminology server issues, but here's my static code review

@Jammjammjamm Jammjammjamm requested a review from tstrass July 6, 2026 12:56
@arscan arscan marked this pull request as ready for review July 7, 2026 21:23
@arscan arscan requested a review from karlnaden July 7, 2026 21:23
@karlnaden karlnaden merged commit d9a36d9 into main Jul 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants