FQM-334: Fix response validation tests#123
Merged
Merged
Conversation
…tests in order sign
1f9da05 to
cff3057
Compare
tstrass
requested changes
Jul 2, 2026
tstrass
left a comment
Contributor
There was a problem hiding this comment.
Haven't been able to test it today due to terminology server issues, but here's my static code review
tstrass
approved these changes
Jul 7, 2026
arscan
approved these changes
Jul 7, 2026
karlnaden
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch removes the old response validation from the 2.2.1 server suite and fully transitions the response validation tests to rely on the logical models validation.
Testing Guidance
The hooks tests should still pass when run against the client suite. The Specific Coverage Responses tests will still fail.
Anticipated Provider-side Test Impact
This update required two minor fixes to the mocked responses in the client suite:
systemActionsfield, which is not allowed in the spec, so this was changed to ensure that thesystemActionsfield is removed if there are no actions.