fix(ci): Resolve CI errors by fixing tool paths in Makefile#13
Conversation
The `go install` command installs binaries to a directory that is not always in the `PATH` of the CI environment. This was causing the `lint`, `format`, and `security` jobs to fail because they could not find the `golangci-lint`, `goimports`, and `gosec` binaries. This commit modifies the `Makefile` to: - Explicitly define `GOPATH` and `GOBIN` using `go env`. - Add a fallback for `GOBIN` to be `$GOPATH/bin` if `go env GOBIN` returns empty. - Update the `lint`, `format`, and `security` targets to check for the tools in `$(GOBIN)` before attempting to install them. - Invoke the tools using their full path `$(GOBIN)/<tool-name>` after installation.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
1 participant
This change fixes the CI errors by modifying the
Makefileto correctly locate and execute Go binaries. It explicitly definesGOBINand updates thelint,format, andsecuritytargets to use the full path to the tools.PR created automatically by Jules for task 1926451022769217673