Fix overriding of flow session tags via exceptions#1505
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a bug in grant_exception_stage_3 where newly created flow rule exceptions used the session's pre-update access_rules_tag value when building the if_has_tag field. The session tag update is moved earlier in the flow so subsequent rule JSON is built with the new tag.
Changes:
- Move the
set_access_rules_taghandling (and the success message) to before access/grading rule JSON construction. - Use the resolved
new_access_rules_tag(rather thansession.access_rules_tag) when populatingif_has_tagfor both the access and grading exception JSONs. - Remove the
not restricted_to_same_tagguard around the tag update.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
inducer
force-pushed
the
fix-tag-override
branch
2 times, most recently
from
08e8989 to
fe0517e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.