fix(core): concurrency cancellation, TOCTOU in callTool, defensive hook copies, and new tests - #6
Open
indrazm wants to merge 1 commit into
Open
fix(core): concurrency cancellation, TOCTOU in callTool, defensive hook copies, and new tests#6indrazm wants to merge 1 commit into
indrazm wants to merge 1 commit into
Conversation
…ok copies, and new tests
- concurrency.ts: add AbortSignal support and stop sibling workers on error
- tool-execution.ts: accept AbortSignal for early cancellation on stream abort
- prompt-request.ts: create AbortController in stream(), abort in finally; add
.catch(() => {}) to detached promise chain; defensively copy newMessages at
all hook call sites to prevent shared-mutable-state corruption
- agent.ts: fix TOCTOU race in callTool() — single get() lookup + callWithTool()
instead of separate contains() + call() lookups
- tool-set.ts: add callWithTool() for atomic tool invocation with pre-resolved ref
- tool-execution.ts, mcp/tool.ts: Symbol.for() -> Symbol() to avoid cross-realm
symbol collisions
- test: concurrency.test.ts (10 tests), compact.test.ts (12 tests),
tool-set.test.ts (+4 TOCTOU tests), prompt-request.test.ts (+2 tests for
unhandled rejection and message integrity)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary here