Refactor core agent types - #5
Open
indrazm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Intention
Refactor core agent type definitions out of
packages/core/src/agent/agent.tsintopackages/core/src/agent/types.ts, then update agent, builder, public, and internal exports to consume the shared type module.Reviews
Review passed with no findings. The reviewer noted the refactor preserves apparent public exports, updates internal imports consistently, and typecheck passed.
Original review output
What Fixed
No fix step was required because review and lint verdicts passed without unresolved findings.
Fix agent output
Lint and Typecheck Status
pnpm typecheckpnpm lint(reported 5 warnings for unused imports, no errors; exit code 0)pnpm testpnpm buildVerification output