refactor: thread caller allocator into worker arenas#369
Merged
Conversation
Each parallel worker arena now sources its backing from the caller instead of pinning `page_allocator`. Production picks `smp_allocator` (thread-safe, no 4 KiB rounding); tests can drive the same workers under `testing.allocator` so leak coverage now extends across the worker boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Threads a caller-chosen allocator into the parallel worker arenas across
install,migrate --parallel,outdated, andsearch. Production pickssmp_allocator(thread-safe, skips the 4 KiB roundingpage_allocatorpaid for every KB-scale formula JSON or temp-path string); tests can now drive the same workers undertesting.allocator, so leak detection finally reaches across the worker boundary. No worker invariant changed - each worker still owns its arena.Related Issue
Notes for Reviewers