Keep posting campaign when frontmatter has no campaign keys#384
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request updates the postingCampaignUuid and agreedPostingCampaignTerm fields across the codebase to support undefined values, allowing these fields to be optional. The changes include updating type definitions, modifying validation logic to handle undefined inputs, adjusting how these fields are serialized and compared, and adding unit tests to verify the new behavior. I have no feedback to provide as there were no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| }); | ||
| }); | ||
|
|
||
| it("returns null for an explicit null", () => { |
There was a problem hiding this comment.
posting_campaign_uuid がない場合に undefined にするテストも欲しいです
There was a problem hiding this comment.
@tomoasleep
こちらのテストは describe("when posting campaign keys are absent in frontmatter") 内の it("keeps them undefined") で追加しています(キーなしのfrontmatterを読み込んで postingCampaignUuid / agreedPostingCampaignTerm が undefined になることを確認しています)。
qiita-cli/src/lib/file-system-repo.test.ts
Lines 144 to 161 in 648002d
もし意図されていたのが別のケースでしたら補足いただけると助かります!
There was a problem hiding this comment.
すみません、そっちのテストを見落としてました 🙏 であれば問題ないと思います。
What
How
Why
Refs