Feat/migrate chem - #136
Draft
droomelotdegendt wants to merge 2 commits into
Draft
Conversation
Separates data warehouse table connections from R business logic to prepare for DWH migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Migrate function
get_chemto new data warehouse 'W0002_10_Watina'.Key changes
build_chem_queryto separate table connections from R business logicDimTijd-->DimDatum)ssrs_StaalENfor the new dim tableDimStaal(which has 2 columns for electroneutrality: StaalElnNbr and ENCalculated)Open questions
ENCalculatedfromDimStaalused for columnelneutr, or shouldStaalElnNbrbe used?filter(.data$ChemVarWID != 24))conc_type = eq?Migration checks
To verify the code changes, the DWH migration snapshots were compared before and after migration (see the testing README for more information). The output is a one-on-one match except for:
CondF(filtered out by the quick fix solution)Siconc_type = eq, the output has different values for the ChemVariableAl,Mn, andP-PO4Note: to only check the DWH query changes, look at feat(get_chem): migrate to new DWH 'W0002_10_WATINA' separately