Skip to content

fix(auth): resolve logout 404 redirect and clean storage cache #83 #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imuniqueshiv merged 2 commits into from
Jul 8, 2026
+31 −8
Merged

fix(auth): resolve logout 404 redirect and clean storage cache #83 #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
544b816
fix(auth): resolve logout 404 redirect and clean storage cache #83
palakgoda Jul 7, 2026
2fd7fa9
fix(auth): reset login state flag and update toast placement per code…
palakgoda Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion client/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 12 additions & 5 deletions client/src/components/Navbar.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import React, { useState, useContext, useEffect, useRef } from "react";
import { useNavigate, useLocation } from "react-router-dom";
import axios from "axios";
import AppContent from "../context/AppContent";
import { toast } from "react-toastify";
import {
Menu,
X,
Expand All @@ -29,7 +30,7 @@ const NAV_LINKS = [
const Navbar = () => {
const navigate = useNavigate();
const location = useLocation();
const { backendUrl, userData, setUserData } = useContext(AppContent);
const { backendUrl, userData, setUserData, setIsLoggedin } = useContext(AppContent);

const [menuOpen, setMenuOpen] = useState(false);
const [mobileOpen, setMobileOpen] = useState(false);
Expand Down Expand Up @@ -138,12 +139,18 @@ const Navbar = () => {
{},
{ withCredentials: true },
);
} catch (err) {
console.warn(
"Backend logout cookie clearance skipped locally:",
err.message,
);
} finally {
setUserData(null);
localStorage.removeItem("userData");
window.location.href = "/login";
} catch (err) {
console.error("Logout failed", err);
window.location.href = "/login";
setIsLoggedin(false);
toast.success("Logged out successfully");

navigate("/");
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}
};

Expand Down
7 changes: 5 additions & 2 deletions client/src/context/AppContext.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import axios from "axios";
import React, {useCallback, useEffect, useState } from "react";
import { toast } from "react-toastify";
import AppContent from "./AppContent.js";

import { useNavigate } from 'react-router-dom';

axios.defaults.withCredentials = true;

Expand All @@ -14,6 +14,7 @@ const [isLoggedin, setIsLoggedin] = useState(false);
const [userData, setUserData] = useState(null);
const [loading, setLoading] = useState(true);
const [isLoggingOut, setIsLoggingOut] = useState(false);
const navigate = useNavigate();

const getUserData = useCallback(async () => {
try {
Expand Down Expand Up @@ -85,6 +86,9 @@ const logoutUser = async () => {
try {
setIsLoggingOut(true);

toast.success("Logged out successfully");

navigate('/'); //FORCE REDIRECT TO LANDING PAGE (Prevents the 404 page)

await axios.post(
`${backendUrl}/api/auth/logout`,
Expand All @@ -98,7 +102,6 @@ setIsLoggingOut(true);
setUserData(null);
localStorage.removeItem("userData");

toast.success("Logged out successfully");
} catch {
toast.error("Failed to logout");
} finally {
Expand Down
Loading