Enhance navigation and search experience #8
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import { Breadcrumbs } from "@/components/breadcrumbs"; | ||
|
|
||
| export default function RGPVLayout({ | ||
| children, | ||
| }: { | ||
| children: React.ReactNode; | ||
| }) { | ||
| return ( | ||
| <> | ||
| <Breadcrumbs /> | ||
| {children} | ||
| </> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| "use client"; | ||
|
|
||
| import Link from "next/link"; | ||
| import { usePathname } from "next/navigation"; | ||
| import { ChevronRight, Home } from "lucide-react"; | ||
|
|
||
| export function Breadcrumbs() { | ||
| const pathname = usePathname(); | ||
| const pathNames = pathname.split("/").filter((path) => path); | ||
|
|
||
| if (pathNames.length <= 1) { | ||
| return null; | ||
| } | ||
|
|
||
| return ( | ||
| <div className="mx-auto w-full max-w-7xl px-6 lg:px-8"> | ||
| <nav aria-label="breadcrumb" className="py-4"> | ||
| <ol className="flex flex-wrap items-center gap-1.5 text-sm text-muted-foreground"> | ||
| <li> | ||
| <Link | ||
| href="/" | ||
| className="flex items-center transition-colors hover:text-foreground focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-blue-500 rounded" | ||
| aria-label="Home" | ||
| > | ||
| <Home className="h-4 w-4" /> | ||
| </Link> | ||
| </li> | ||
| {pathNames.length > 0 && <ChevronRight className="h-4 w-4" />} | ||
| {pathNames.map((link, index) => { | ||
| const href = `/${pathNames.slice(0, index + 1).join("/")}`; | ||
| const isLast = index === pathNames.length - 1; | ||
| const label = decodeURIComponent(link) | ||
| .replace(/-/g, " ") | ||
| .replace(/\b\w/g, (char) => char.toUpperCase()); | ||
|
|
||
| return ( | ||
| <li key={href} className="flex items-center gap-1.5"> | ||
| {isLast ? ( | ||
| <span | ||
| className="font-medium text-foreground" | ||
| aria-current="page" | ||
| > | ||
| {label} | ||
| </span> | ||
| ) : ( | ||
| <> | ||
| <Link | ||
| href={href} | ||
| className="transition-colors hover:text-foreground focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-blue-500 rounded" | ||
| > | ||
| {label} | ||
| </Link> | ||
| <ChevronRight className="h-4 w-4" /> | ||
| </> | ||
| )} | ||
| </li> | ||
| ); | ||
| })} | ||
| </ol> | ||
| </nav> | ||
| </div> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,6 +43,7 @@ export default function Universities() { | |
|
|
||
| const filteredUniversities = universities.filter((uni) => { | ||
| const query = searchQuery.trim().toLowerCase(); | ||
| if (!query) return true; | ||
| return ( | ||
| uni.name.toLowerCase().includes(query) || | ||
| uni.fullName.toLowerCase().includes(query) || | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Keep
<ol>children limited to<li>elements.Line 28 inserts the separator directly under the ordered list, which produces invalid list markup and weakens breadcrumb semantics for assistive tech. Wrap that separator in an
<li aria-hidden="true">(or move separators inside adjacent list items) so every direct child of<ol>is an<li>.Proposed fix
<ol className="flex flex-wrap items-center gap-1.5 text-sm text-muted-foreground"> <li> <Link href="/" className="flex items-center transition-colors hover:text-foreground focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-blue-500 rounded" aria-label="Home" > <Home className="h-4 w-4" /> </Link> </li> - {pathNames.length > 0 && <ChevronRight className="h-4 w-4" />} + {pathNames.length > 0 && ( + <li aria-hidden="true"> + <ChevronRight className="h-4 w-4" /> + </li> + )}📝 Committable suggestion
🤖 Prompt for AI Agents