Skip to content

chore: add shared functions#325

Merged
Oran-Dan merged 4 commits into
feat/export-statesfrom
fix/tmp
Apr 15, 2026
Merged

chore: add shared functions#325
Oran-Dan merged 4 commits into
feat/export-statesfrom
fix/tmp

Conversation

@Oran-Dan

Copy link
Copy Markdown
Contributor

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

Be sure to reference any related issues by adding fixes issue #.

How the change has been tested

Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have successfully tested this change in a docker environment

@Oran-Dan Oran-Dan self-assigned this Apr 15, 2026
@Oran-Dan Oran-Dan changed the base branch from beta to feat/export-states April 15, 2026 09:32
@Oran-Dan Oran-Dan marked this pull request as ready for review April 15, 2026 09:33
@Oran-Dan Oran-Dan changed the title Fix/tmp chore: add shared functions Apr 15, 2026
@codecov-commenter

codecov-commenter commented Apr 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
agent_shared/src/credential_status_checker.rs 66.66% 1 Missing ⚠️
Files with missing lines Coverage Δ
agent_holder/src/credential/aggregate.rs 57.14% <100.00%> (-8.25%) ⬇️
agent_identity/src/services.rs 94.24% <100.00%> (-0.53%) ⬇️
...src/application/access_token_validation_service.rs 100.00% <100.00%> (ø)
agent_shared/src/lib.rs 63.41% <100.00%> (+25.91%) ⬆️
agent_shared/src/credential_status_checker.rs 86.66% <66.66%> (-1.34%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Oran-Dan Oran-Dan merged commit 5346db9 into feat/export-states Apr 15, 2026
2 checks passed
@Oran-Dan Oran-Dan deleted the fix/tmp branch April 15, 2026 11:19
Comment thread agent_shared/src/lib.rs
Comment on lines +53 to +63
/// Get the claims from a JWT without performing validation.
pub fn get_unverified_jwt_claims(jwt: &serde_json::Value) -> Option<serde_json::Value> {
jwt.as_str()
.and_then(|string| string.splitn(3, '.').collect::<Vec<&str>>().get(1).cloned())
.and_then(|payload| {
URL_SAFE_NO_PAD
.decode(payload)
.ok()
.and_then(|payload_bytes| serde_json::from_slice::<serde_json::Value>(&payload_bytes).ok())
})
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this relates to your comment here right @Oran-Dan ?

nanderstabel added a commit that referenced this pull request Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants